Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List pull requests again #1303

Closed
vermiculus opened this issue Oct 12, 2016 · 6 comments · Fixed by #1666
Closed

List pull requests again #1303

vermiculus opened this issue Oct 12, 2016 · 6 comments · Fixed by #1666
Labels

Comments

@vermiculus
Copy link
Contributor

#1232 mentions the need for a command to list out pull requests (taken away by 8563e67, probably for semantic reasons), but I thought I'd reiterate the need here.

Related to vermiculus/magithub#44.

@akshatgoel
Copy link

akshatgoel commented Nov 8, 2016

@mislav I am looking to work on this issue. Here is my current understanding of the issue:
Currently hub only has command pull-request to create a PR but not list them. We should be able to list PRs as we do with issues right now (as added by the commit 8563e67).

Proposal:
I am thinking of moving current pull-request behavior to sub-command create to maintain parity with issue as well as to make listing (which is stateless operation compared to create) as default.

What do you think?

@mislav
Copy link
Owner

mislav commented Nov 9, 2016

@akshatgoel That's a good plan. How do you envision this command and its subcommands to be called?

@timja
Copy link

timja commented Jan 19, 2017

Alternatively hub ls pull-request?

@vermiculus
Copy link
Contributor Author

vermiculus commented Feb 12, 2017

Even if there could be an option to skip this section of code, that would be sufficient:

for _, issue := range issues {
	if issue.PullRequest != nil {
		continue
	}
	ui.Printf(formatIssue(issue, flagIssueFormat, colorize))
}

@vermiculus
Copy link
Contributor Author

@mislav If such a flag was added this week, do you have an estimate on when the change would make it into a release?

In other words, any idea when 2.3.0-pre9 will be tagged?

vermiculus added a commit to vermiculus/hub that referenced this issue Feb 15, 2017
This change adds a long-form flag `--show-pulls` to `hub issue` that
directs hub to include pull requests in the issue listing.  The
default value is false; the default behavior does not change.

Temporary fix until a better abstraction for pull requests can be
designed.

Related: mislav#1303
Related: vermiculus/magithub#44
@mislav
Copy link
Owner

mislav commented Feb 15, 2017

I could tag another prerelease after that. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants