Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove support for const #1910

Merged
merged 1 commit into from
May 12, 2017
Merged

remove support for const #1910

merged 1 commit into from
May 12, 2017

Conversation

alexlamsl
Copy link
Collaborator

As this is not part of ES5.

Will need to skip/revert this in the next merge onto harmony.

@Martii
Copy link
Contributor

Martii commented May 11, 2017

FYI: This is present in ES5.1 as part of Fx... grey area before ECMAScript did some version standardization.

@alexlamsl
Copy link
Collaborator Author

@Martii thanks for the information. The decision is made based on the fact that most code libraries targetting ES5 out there would not use const, so this is practically a non-feature.

uglify-es will remain to support const, albeit someone will need to fix #1903

This was referenced May 11, 2017
Closed
Closed
@kzc kzc mentioned this pull request May 11, 2017
Merged
@alexlamsl alexlamsl changed the title remove support for const [WIP] remove support for const May 11, 2017
@alexlamsl alexlamsl changed the title [WIP] remove support for const remove support for const May 11, 2017
@alexlamsl
remove support for const
ca904e2 
As this is not part of ES5.
@alexlamsl alexlamsl merged commit c391576 into mishoo:master May 12, 2017
@alexlamsl alexlamsl deleted the issue-1903 branch May 12, 2017 06:57
alexlamsl added a commit to alexlamsl/UglifyJS that referenced this pull request May 15, 2017
@alexlamsl
Revert "remove support for const (mishoo#1910)"
cd6e849 
This reverts commit c391576.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlamsl @Martii