Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the empty ISO icon image, removing unused resources #2

Closed
wants to merge 1 commit into from

Conversation

john-peterson
Copy link
Member

Discussion

[02:55] @Jasper Sonicadvance1, pull request #2 looks fine
[02:56] @Jasper cuts down on binary size
[02:56] @Jasper no downside afaict
[02:57] @Jasper well there's some crazy custom drawing code that doesn't really make sense

…mpty tab icon image.

Replacing the gc, wii, wad icons and including the original files in the repo to allow tweaking and regenearating the miniatures. These images reflect the official logo better than the previous images. The images are also perfectly centered compared to previously.

Drawing the images manually in EVT_PAINT again to draw them on top of the row selection marker. Its by default drawn on top of the images and it isn't drawn in the transparent parts of a column image which is esthetically unpleasing.

Removed unused resources.
Renamed and moved resources for order and consistency.
@john-peterson
Copy link
Member Author

This might have been aesthetically appealing ten years ago. I don't think I will ever bother about this. It seems to only be important in appearance. It has no meaning beyond appearance of various copyrighted images that I would avoid using

I'm looking for engineering that I might be interested in in the future. I think this can be safely forgotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant