Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-auto-import from 1.12.0 to 2.2.4 #2311

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

SergeAstapov
Copy link
Collaborator

This is breaking change and will require major version bump.

Per ember-auto-import 1.x to 2.x migration guide:

addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, so they should do their own semver major releases when they upgrade

There is a bunch of wins (especially performance) for apps that update to e-a-i v2 and e-a-i v2 will be a hard requirement for apps to run Ember v4 (which should not be big deal as apps running v2 should be able to use addons running e-a-i v1, but why not).
There is great write up from @buschtoens about this https://twitter.com/buschtoens/status/1449745386571247620

@SergeAstapov SergeAstapov added the Breaking Pull requests that include breaking changes label Jan 14, 2022
@SergeAstapov SergeAstapov merged commit 574f880 into miragejs:master Jan 14, 2022
@SergeAstapov SergeAstapov deleted the bump-ember-auto-import branch January 14, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Pull requests that include breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant