Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getWithDefault deprecated on Ember canary #1970

Closed
gitKrystan opened this issue May 29, 2020 · 0 comments
Closed

getWithDefault deprecated on Ember canary #1970

gitKrystan opened this issue May 29, 2020 · 0 comments

Comments

@gitKrystan
Copy link
Contributor

Our Ember canary tests are failing with:

Error: Using getWithDefault has been deprecated. Instead, consider using Ember get and explicitly checking for undefined.

See emberjs/rfcs#554

Looks like getWithDefault is used here in startMirage:

let discoverEmberDataModels = getWithDefault(env['ember-cli-mirage'] || {}, 'discoverEmberDataModels', true);

I can open a PR with a proposed fix.

gitKrystan added a commit to gitKrystan/ember-cli-mirage that referenced this issue May 29, 2020
Deprecated by Ember RFC#554
gitKrystan added a commit to gitKrystan/ember-cli-mirage that referenced this issue May 29, 2020
Deprecated by Ember RFC#554
gitKrystan added a commit to gitKrystan/ember-cli-mirage that referenced this issue May 29, 2020
Deprecated by Ember RFC#554
chancancode added a commit that referenced this issue Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant