Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a pause when we iter on the index file and when we decompress a PACK file #631

Merged
merged 7 commits into from
Feb 11, 2024
Merged

Give a pause when we iter on the index file and when we decompress a PACK file #631

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
42ad399
Give a pause when we iter on the index file and when we decompress a …
dinosaure Dec 21, 2023
af3d417
Try to pause to each entries of the incoming PACK file
dinosaure Feb 5, 2024
ee586a5
Give a pause when we try to load an object from a PACK file on the lw…
dinosaure Feb 5, 2024
b9de001
Update src/git/mem.ml
dinosaure Feb 5, 2024
0151247
Add some Lwt.pause to be more cooperative with other processes
dinosaure Feb 8, 2024
7c17df1
Add a lower bound on rresult package
dinosaure Feb 9, 2024
64b1bf5
Act read_inflated as an I/O action
dinosaure Feb 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/git/mem.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,8 +330,13 @@ module Make (Digestif : Digestif.S) = struct
in
let iter index ~f =
let f (uid, offset) = f uid offset in
let f ~uid ~offset ~crc:_ = Lwt.apply f (uid, offset) in
Carton.Dec.Idx.map ~f index |> Lwt.join
(* XXX(dinosaure): when the pack is huge, we must give a pause
for each entry because our [batch_write] tries to extract all
objects the second time. *)
let f ~uid ~offset ~crc:_ =
Lwt.apply f (uid, offset) >>= fun res ->
Lwt.pause () >>= Lwt.return res in
dinosaure marked this conversation as resolved.
Show resolved Hide resolved
Carton.Dec.Idx.map ~f index |> Lwt.join >>= Lwt.pause
in
let map pck_contents ~pos len =
let pos = Int64.to_int pos in
Expand Down