forked from valtech-sd/react-native-video
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sync): Update to 6.6.3 #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spelling error (TheWidlarzGroup#4014) (TheWidlarzGroup#4042) * fix(android): updated getLicense call to work with new syntax, and fixed spelling error (TheWidlarzGroup#4014) * fix(android): corrected error with my refactor (TheWidlarzGroup#4014) * fix(android): Removed trailing space (TheWidlarzGroup#4014) * fix(ios): Refactored following review (TheWidlarzGroup#4014) * fix(ios): Lint tidy (TheWidlarzGroup#4014) * fix(ios): Removed incorrect semi-colon (TheWidlarzGroup#4014) * fix(ios): Fixed more lint errors (TheWidlarzGroup#4014) --------- Co-authored-by: Darren Taft <darren.taft@bt.com>
* fix metadata update race * merge nowPlayingInfo instead of overriding it * update method name * fix code style
…dlarzGroup#4011) * Rename .java to .kt * refactor(android): migrate ReactExoplayerViewManager to Kotlin * fix: lint error * refactor: setPreventsDisplaySleepDuringVideoPlayback function
…function (TheWidlarzGroup#4054) * fix(android): return value for getCurrentPosition function * fix: remove additional casting
…oup#4050) * fix(ios): override source metadata with custom metadata * lint code
* chore: update method document * chore: update method document * chore: update method document * fix: PR feedback * chore: update description for controls prop
…rzGroup#4078) * refactor(android): migrate DefaultDashChunkSource to Kotlin
* infra: update stale action * infra: add issue validator * code clean * add missing labels * fix reproduction check * code clean * add version check * fix version check * add missing label * add note to version message * code clean * update stale message
…eWidlarzGroup#4090) * feat: support for hiding duration on Android * docs: add hideDuration property to control styles documentation
* fix: ios build crash due to AVMediaSelectionGroup not being unwrapped * fix: use shorthand optional binding * fix: disable swiftlint shorthand_optional_binding for guard let * fix(ios): use guard do catch Co-authored-by: Krzysztof Moch <krzysmoch.programs@gmail.com> --------- Co-authored-by: Krzysztof Moch <krzysmoch.programs@gmail.com>
TheWidlarzGroup#4060) * fix(android): hide surfaceView for loading time when shutter is hidden * fix: hide/show surface view without casting
…up#4034) * feat(VideoNativeComponent.ts): add support for cmcd configuration in VideoSrc type to enable cmcd feature on android feat(video.ts): introduce CmcdMode enum and CmcdConfiguration type to define cmcd configuration options * feat(Video.tsx): add support for CMCD configuration in Video component to handle Content Management and Delivery (CMCD) headers for Android platform. * feat(CMCDProps.kt): add CMCDProps class to handle CMCD related properties and parsing logic for React Native module * feat(CMCDConfig.kt): add CMCDConfig class to handle CMCD configuration for ExoPlayer with support for custom data and configuration options. * feat(ReactExoplayerViewManager.java): add support for CMCD configuration in ReactExoplayerViewManager to enable Content Management and Control Data (CMCD) for better video playback optimization. * feat(ReactExoplayerView.java): add support for setting CmcdConfiguration.Factory to customize CMCD configuration for media playback * feat(Source.kt): add support for CMCD properties linked to the source to enhance functionality and data handling * docs(props.mdx): add documentation for configuring CMCD parameters in the component, including usage examples and default values * refactor(ReactExoplayerViewManager.java): remove unused PROP_CMCD and prevCmcdConfig variables to clean up code and improve readability * refactor(Video.tsx): simplify cmcd configuration logic for better readability and maintainability * docs(props.mdx): improve props documentation for clarity and consistency feat(props.mdx): add definitions for CmcdMode enum and CmcdData type to enhance understanding of CMCD data structure and usage * refactor(CMCDProps.kt): refactor CMCDProps class to data class for improved readability and immutability - update CMCDProps class to use List instead of Array for properties * refactor(Video.tsx): refactor createCmcdHeader function to improve code readability and reduce duplication * fix(CMCDProps.kt): remove import statement for CmcdConfiguration * feat(ReactExoplayerView.java): add support for CMCD configuration in ReactExoplayerView component feat(ReactExoplayerViewManager.java): remove redundant CMCD configuration logic from ReactExoplayerViewManager to simplify code and improve maintainability * fix(Video.tsx): merge _cmcd memo into src memo for optimization
* add prop adLanguage; add docs * add native code ios&android for adLanguage props * add missing function to adsLoader and imafactory * Update docs/pages/component/ads.md Language correction Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com> --------- Co-authored-by: Guy <guyha@reshet.tv> Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
* chore: move MultiValueControl & toggleControl to component * fix(sample): fix import / export to avoid circular deps * chore(sample): fix warning
…arzGroup#4121) * fix(sample): align dependencies and fix local asset playback
…idlarzGroup#4123) * fix(ios): ensure behavior is correct with empty text track list
* fix: refactor side loaded text tracks management More textTracks in source. android/ios: ensure text tracks are not selected by default android/ios make textTrack field not nullable clean up doc check compatibility with the old api Add comments on deprecated JS apis Apply API change on basic sample * chore: fix linter * fix(ios): fix build with caching & remove warnings
…1.13.1 / androidxActivity 1.8.2 (TheWidlarzGroup#4173)
…or notification controls (TheWidlarzGroup#4172) * fix: add check for existing VideoPlaybackService in AndroidManifest * Update src/expo-plugins/withNotificationControls.ts Co-authored-by: Seyed Mostafa Hasani <seyedmostafahassani@gmail.com> * fix: comment spacing --------- Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com> Co-authored-by: Seyed Mostafa Hasani <seyedmostafahassani@gmail.com>
…#4174) * chore(android): add null check for id of videoFormat * chore: null check videoFormat.id on onBandwidthSample * fix: PR feedback * fix: linter error * chore: update trackId fallback value
* minimal api * add suport for `getLicense` * update logic for obtaining `assetId` * add support for localSourceEncryptionKeyScheme * fix typo * fix pendingLicenses key bug * lint code * code clean * code clean * remove old files * fix tvOS build * fix errors loop * move `localSourceEncryptionKeyScheme` into drm params * add check for drm type * use DebugLog * lint * update docs * lint code * fix bad rebase * update docs * fix crashes on simulators * show error on simulator when using DRM * fix typos * code clean
* chore(infra): hide prev comments from bot * fix comment format
* fix(tvos): typo * lint
* feat(android): enable to hide specific controls * fix: ts * fix: lint * docs: update `controlsStyles` docs
b99dc09
to
1156729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.