-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember can v2 #94
Merged
Merged
Ember can v2 #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Apr 9, 2019
villander
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will prepare for v2.0 release
Issue: #82 #89
New features
undefined
as a model tocan
orcannot
it do not override a model defined in class definition.parseProperty()
method to use eg. custom prefix likeis
(isReadable) instead ofcan
(canReadable)this.can.valueFor('createProjects', 'account', model, properties)
Deprecations
CanMixin
as it will be removed. You can reproduce its behavior usingcan
service and its methods.import { CanService } from 'ember-can'
->import CanService from 'ember-can/services/can'
import { ability } from 'ember-can'
->import { ability } from 'ember-can/computed'
build
method ofcan
service will be replaced byabilityFor
Breaking changes
null
model if you want to pass only parameters tocan
orcannot
methods ofcan
service. Eg:this.get('canService').can('post', null, { test: true })
model
passed to helpers orcan
service methods, as from now on, can be anything instead of an Ember.Object instance.can
andcannot
methods will always return a booleanedit posts
->edit post
. All abilities files should be created with the SINGULAR form