Change Ember Object Reopen to using purely the initialize function

[tben]

The most recent ember-resolver (v13) update has removed the use of ember objects in the resolver class. So reopen no longer works. This pulse attempts to fix it

[mkszepp]

In generally using private properties of ember is never good option.

I have tested some ways how we can avoid using privates and also without making again a braking change, but unfurtanally there is no clean fix possible without making braking change (also asked shortly to @NullVoxPopuli)
We need to move resolver changes into the app.

Possible fixes for this issue are something like:

import Resolver from 'ember-resolver';
import Application from '@ember/application';
import { withAbilities } from 'ember-can';

class MyApp extends Application {
  Relsolver = withAbilities(Resolver);
}

or

import { Resolver } from 'ember-can';
import Application from '@ember/application';

class MyApp extends Application {
  Relsolver = Resolver;
}

@RobbieTheWagner which fix do you prefer?

[NullVoxPopuli]

with @embroider/macros you could make a non-breaking change.

this library never declared support for ember-resolver 13, so you can use macros to say, for ember-resolver < 12, do what you've been doing, and for v13+, do the new thing

this would then be a minor release 🎉

[mkszepp]

@NullVoxPopuli ember-resolver v13 is already whitelisted...

ember-can/ember-can/package.json

Line 132 in 7a58baa

"ember-resolver": ">= 8.0.0"

Of course we can do something like this, but when ember-cli brings in next time ember-resolver v13, app are running into this issue and they need to look into instructions

[NullVoxPopuli]

aye, but >= is a optimistic support. It doesn't mean you guarantee all support for all versions.
>= is a library maintainer's friend, because updating every major to include a range is too much work -- it'd be better if things "work by accident", and then if something doesn't issues are reported.

For example, with most addons choosing >= for ember-source, there is not legit expectation (I hope) that there are 0 problems when upgrading ember-source across majors. Just -- if it works great, if not, we report the issue and fix / get a patch release out.

So, in the way of providing a different behavior for ember-resolver 13, since that is a major version bump, I think it makes sense if ember-can has different instructions for that version without a major bump of its own version.
(I hope this makes sense! <3)

[mkszepp]

added PR for fixing ember-resolver v13... see #186