-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't export private normalize.ts
function & refactor tests
#171
Conversation
@RobbieTheWagner i thinks this is now the last part, what we have needed. From my side, i think that we are now ready for next release |
@Exelord friendly ping. |
@mkszepp I got things released, but I am hitting some issues. It seems like our test generators are not creating tests that work. Like |
@RobbieTheWagner hmm... tested last v5 release and we are running in a issue with pluralization... not sure why addon test app works fine... looks like we need in apps the initializer... which we have removed while v2 addon migration... see #166 (comment) i will look how we can bring this inside v2 addon. Maybe this is only needed, because the service is plurale 'abilities' instead of 'ability', but this plural service was introduced while v4... see #152 |
Looking the code-part of initializer it seems to me also a little bit "hacky"... there was added a resolver inside a initializer and the initializer was exported as empty function :( https://github.com/minutebase/ember-can/blob/v4.2.0/addon/initializers/setup-ember-can.js import Resolver from 'ember-resolver';
Resolver.reopen({
init() {
this._super(...arguments);
this.set('pluralizedTypes.ability', 'abilities');
},
});
export function initialize() {}
export default { initialize }; |
How does the actual code resolve which ability to use? We should probably just recommend the same thing for tests. |
the issue is not only in tests... also when you use |
in test-app there was never tested a ability :( i have now added one, so maybe i can find a fix |
@RobbieTheWagner here a possible fix for our issue.. see #176. i haven't found no other fix... it looks like initializer exports are not working in v2... I think this is also a clean way instead of current way |
This should be the last changes what we need to do for getting ready next release.
With this changes we are shipping the
normalize.ts
private and peoples which were using public, are getting the error.The test-app has used "public" this functions. As its not anymore possible it was necessary to use the service to make tests compatible with this last changes.
As this function was always declared as private, its no braking change