DT-1254 update swagger to use OpenAPI Spec v3 #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ofjustice/prison-api into tm-dt-1254-update-swagger-to-v3
tomsmyers
commented
Oct 27, 2020
| testImplementation 'org.glassfish:javax.el:3.0.0' | ||
| testImplementation 'io.swagger.parser.v3:swagger-parser:2.0.20' |
There was a problem hiding this comment.
required to downgrade due to json deserialization bug introduced here swagger-api/swagger-parser#1400 and discussed here javalin/javalin#1079 and here swagger-api/swagger-core#3637
tomsmyers
commented
Oct 27, 2020
| @@ -67,7 +65,8 @@ public Docket docket() { | |||
| .directModelSubstitute(LocalDateTime.class, Date.class) | |||
| .directModelSubstitute(LocalDate.class, java.sql.Date.class) | |||
| .securityContexts(Lists.newArrayList(securityContext())) | |||
| .securitySchemes(Lists.newArrayList(apiKey)); | |||
| .securitySchemes(Lists.newArrayList(apiKey)) | |||
| .forCodeGeneration(true); | |||
There was a problem hiding this comment.
required to stop classes using inheritance being named with invalid characters
e.g. before we would have Page«PrisonerInformation»
after we have PageOfPrisonerInformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.