Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-1685: Show relevant error when not selecting a file to upload #985

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

acsauk
Copy link
Contributor

@acsauk acsauk commented Jan 24, 2024

Purpose

Fixes MLPAB-1685

@acsauk acsauk marked this pull request as ready for review January 24, 2024 16:56
@acsauk acsauk requested a review from a team as a code owner January 24, 2024 16:56
@acsauk acsauk temporarily deployed to dev_985mlpab168 January 24, 2024 17:12 — with GitHub Actions Inactive
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01d59d5) 91.94% compared to head (b0690f6) 91.95%.
Report is 1 commits behind head on main.

❗ Current head b0690f6 differs from pull request most recent head e244af4. Consider uploading reports for the commit e244af4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #985   +/-   ##
=======================================
  Coverage   91.94%   91.95%           
=======================================
  Files         180      180           
  Lines        9848     9854    +6     
=======================================
+ Hits         9055     9061    +6     
  Misses        677      677           
  Partials      116      116           
Flag Coverage Δ
unittests 91.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acsauk acsauk temporarily deployed to dev_985mlpab168 January 24, 2024 17:37 — with GitHub Actions Inactive
@acsauk acsauk temporarily deployed to dev_985mlpab168 January 25, 2024 10:44 — with GitHub Actions Inactive
@acsauk acsauk merged commit 35ab83c into main Jan 25, 2024
23 checks passed
@acsauk acsauk deleted the MLPAB-1685 branch January 25, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants