Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-1484 Escape data passed to templated translation messages #964

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

hawx
Copy link
Contributor

@hawx hawx commented Jan 16, 2024

https://github.com/nicksnyder/go-i18n/blob/main/v2/internal/template.go#L7 is the line that we'd need to change, but given we don't actually use much of the package I thought it might be easier writing this. It also opens up a bit more flexibility, e.g. if we wanted to simplify Welsh plural forms in the future.

@hawx hawx self-assigned this Jan 16, 2024
@hawx hawx requested a review from a team as a code owner January 16, 2024 13:53
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (17e40a0) 91.68% compared to head (5c191b6) 91.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/event-received/cloud_watch_event_handler.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   91.68%   91.78%   +0.09%     
==========================================
  Files         170      172       +2     
  Lines        9484     9599     +115     
==========================================
+ Hits         8695     8810     +115     
  Misses        674      674              
  Partials      115      115              
Flag Coverage Δ
unittests 91.78% <99.29%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hawx hawx force-pushed the MLPAB-1484-escape-tr-format-html branch from aaa094b to 06e4597 Compare January 16, 2024 14:14
@hawx hawx force-pushed the MLPAB-1484-escape-tr-format-html branch from 06e4597 to d45de7d Compare January 16, 2024 14:38
Copy link

github-actions bot commented Jan 16, 2024

PR Environment Terraform Plan Summary

Plan: 1 to add, 4 to change, 1 to destroy

@hawx hawx temporarily deployed to dev_964mlpab148 January 16, 2024 14:57 — with GitHub Actions Inactive
@hawx hawx force-pushed the MLPAB-1484-escape-tr-format-html branch from d45de7d to f2dc732 Compare January 16, 2024 15:15
@hawx hawx temporarily deployed to dev_964mlpab148 January 16, 2024 15:36 — with GitHub Actions Inactive
@hawx hawx force-pushed the MLPAB-1484-escape-tr-format-html branch 2 times, most recently from 3129b58 to 974aec4 Compare January 18, 2024 09:49
@hawx hawx force-pushed the MLPAB-1484-escape-tr-format-html branch from 974aec4 to dda8c4c Compare January 18, 2024 10:25
@hawx hawx temporarily deployed to dev_964mlpab148 January 18, 2024 10:45 — with GitHub Actions Inactive
@hawx hawx force-pushed the MLPAB-1484-escape-tr-format-html branch from dda8c4c to 5c191b6 Compare January 18, 2024 10:53
Copy link
Contributor

@acsauk acsauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, hopefully we can look at how often (if ever) our translations fall into the 4 variations of pluralisms for Welsh and slim that down if it turns out they're the same everywhere.

:shipit:

@hawx hawx merged commit a8bead5 into main Jan 18, 2024
24 checks passed
@hawx hawx deleted the MLPAB-1484-escape-tr-format-html branch January 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants