-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLPAB-1484 Escape data passed to templated translation messages #964
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #964 +/- ##
==========================================
+ Coverage 91.68% 91.78% +0.09%
==========================================
Files 170 172 +2
Lines 9484 9599 +115
==========================================
+ Hits 8695 8810 +115
Misses 674 674
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aaa094b
to
06e4597
Compare
06e4597
to
d45de7d
Compare
PR Environment Terraform Plan SummaryPlan: 1 to add, 4 to change, 1 to destroy |
d45de7d
to
f2dc732
Compare
3129b58
to
974aec4
Compare
974aec4
to
dda8c4c
Compare
dda8c4c
to
5c191b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job, hopefully we can look at how often (if ever) our translations fall into the 4 variations of pluralisms for Welsh and slim that down if it turns out they're the same everywhere.
https://github.com/nicksnyder/go-i18n/blob/main/v2/internal/template.go#L7 is the line that we'd need to change, but given we don't actually use much of the package I thought it might be easier writing this. It also opens up a bit more flexibility, e.g. if we wanted to simplify Welsh plural forms in the future.