MLPAB -1378. MLPAB-1725: Add personal details warnings for subsequent lpas, update content #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r details (for now)
PR Environment Terraform Plan SummaryPlan: 1 to add, 4 to change, 1 to destroy |
hawx
reviewed
Jan 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #961 +/- ##
==========================================
+ Coverage 91.53% 91.68% +0.14%
==========================================
Files 168 170 +2
Lines 9322 9484 +162
==========================================
+ Hits 8533 8695 +162
Misses 674 674
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
acsauk
commented
Jan 16, 2024
| @@ -768,7 +768,7 @@ | |||
| "startNow": "Start now", | |||
| "youCanIncludeRestrictionsAboutLst": "You can also include any restrictions and conditions you have about life-sustaining treatment.", | |||
| "youMustChooseANewCertificateProvider": "You must choose a different certificate provider", | |||
| "youMustChooseANewCertificateProviderContent": "<p class=\"govuk-body\">As you’ve known {{ .CertificateProviderFullName }} for less than 2 years, they cannot be your certificate provider.</p> <p class=\"govuk-body\">Select Continue to choose a different certificate provider.</p>", | |||
| "youMustChooseANewCertificateProviderContent": "<p class=\"govuk-body\">As you’ve known {{ .CertificateProviderFullName }} for less than 2 years, they cannot be your certificate provider.</p> <p class=\"govuk-body\">Select <span class=\"govuk-!-font-weight-bold\">Continue</span> to choose a different certificate provider.</p>", | |||
There was a problem hiding this comment.
I snuck this in as its a one-line change for MLPAB-1725.
hawx
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During development, we identified a gap in the flow for additional LPAs where the donor won't see the can you sign online question if they are redirected to language preferences. Rather than complicate the logic in different handlers we decided to redirect to your details after creating a new LPA to show all the questions again. While not ideal, we know we want to break up your details in to single question pages so we will handle the page ordering when we pick up this piece of work again after supported journeys.
This change also adds the event received lambda to localstack to see when new LPAs are created (rather than manually emitting the event). I've not yet thought through how this interacts with other events for the payment process coming in. Still, it feels like it may give us a little more freedom while developing locally without having to rely on emitting events via our image-based lambda container and instead route everything through localstack.
Fixes MLPAB-1378, MLPAB-1725