MLPAB-397: How should the attorneys make decisions #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.37% // Head: 93.42% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 93.37% 93.42% +0.04%
==========================================
Files 46 47 +1
Lines 2506 2569 +63
==========================================
+ Hits 2340 2400 +60
- Misses 129 131 +2
- Partials 37 38 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hawx
reviewed
Nov 4, 2022
hawx
approved these changes
Nov 4, 2022
| "jointlyAndSeverallyMixed": "Jointly for some decisions, and jointly and severally for other decisions", | ||
| "jointlyAndSeverallyMixedHint": "Attorneys must agree unanimously on some decisions, but can make others on their own. The donor must state which decisions need to be agreed unanimously.", | ||
| "decisionDetailsHint": " Please tell us which decisions the donor wants to be made jointly. These decisions will be printed on a extra sheet that the donor will need to sign and date. Take a look at the guidance for examples of how the donor can make their wishes clear.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Prompts the donor to confirm on how multiple attorneys should act. Single attorneys won't be shown the question.
Fixes MLPAB-397
Approach
I've extended the radios partial to allow conditionally revealing textareas. This code has got a little busy now and there may be a cleaner way to implement this so open for feedback there.
Learning
There's a known aria bug related to conditionally revealing inputs using the GDS radio component. I've excluded that specific rules in the cypress tests until its resolved.
Checklist