MLPAB-2760: Allow donor to delete voucher after access code used #1821
+701
−515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1821 +/- ##
=======================================
Coverage 95.06% 95.07%
=======================================
Files 287 287
Lines 17058 17062 +4
=======================================
+ Hits 16217 16221 +4
Misses 663 663
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bb48142 to
872a073
Compare
b04d31c to
5c3e35d
Compare
5c3e35d to
ce4f110
Compare
53c60ed to
3bff6d6
Compare
MLPAB-2760 fix and prevent clear chaining
3bff6d6 to
1d790bb
Compare
hawx
previously approved these changes
Mar 5, 2025
f481db2 to
dcb32dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes MLPAB-2760
I was going to tackle the flaky tests separately, but I had 5 different failures in a row so rolled it into this ticket. The main change was decoupling chained commands that cypress advises are unsafe to chain. Let's see if this makes things more stable in the long run...