Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2806 - pull spec during docker build #1729

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Jan 16, 2025

Purpose

Drop requests to raw.githubusercontent.com at the network firewall

Fixes MLPAB-2806

Approach

  • Download spec file for imposter during docker build
  • use dev docker compose override to mount volume for local dev of mock-pay

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (f0436ef) to head (6e3693c).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
+ Coverage   95.03%   95.05%   +0.01%     
==========================================
  Files         285      285              
  Lines       16487    16487              
==========================================
+ Hits        15669    15672       +3     
+ Misses        646      644       -2     
+ Partials      172      171       -1     
Flag Coverage Δ
unittests 95.05% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewpearce-digital andrewpearce-digital merged commit 814cb08 into main Jan 17, 2025
31 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2806-pull-mock-pay-specs-during-docker-build-rather-than-on-container-start branch January 17, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants