Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2793 - use pull through cache for otel collector #1721

Conversation

andrewpearce-digital
Copy link
Contributor

Purpose

Remove use of public ecr images, starting with otel collector (ssm agent is not being used at present).

Fixes MLPAB-2793

Approach

  • use pull through cache host for otel collector image

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.05%. Comparing base (2d0722e) to head (aaa5797).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1721   +/-   ##
=======================================
  Coverage   95.05%   95.05%           
=======================================
  Files         285      285           
  Lines       16408    16408           
=======================================
  Hits        15596    15596           
  Misses        642      642           
  Partials      170      170           
Flag Coverage Δ
unittests 95.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@acsauk acsauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andrewpearce-digital andrewpearce-digital merged commit f0edacf into main Jan 15, 2025
32 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2793-make-and-use-an-ecr-pull-through-cache-for-the-otel-collector-image-used-by-the-app-ecs-service branch January 15, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants