Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-2575 - use tls rules to make an allow list #1720

Conversation

andrewpearce-digital
Copy link
Contributor

@andrewpearce-digital andrewpearce-digital commented Jan 14, 2025

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (816d7bd) to head (aba8ace).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1720   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         285      285           
  Lines       16452    16452           
=======================================
  Hits        15637    15637           
  Misses        644      644           
  Partials      171      171           
Flag Coverage Δ
unittests 95.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewpearce-digital andrewpearce-digital force-pushed the MLPAB-2575-crit-implement-network-firewall-for-outbound-traffic-control-from-vpc branch from 3297571 to aba8ace Compare January 16, 2025 10:46
@andrewpearce-digital andrewpearce-digital marked this pull request as ready for review January 16, 2025 10:47
@andrewpearce-digital andrewpearce-digital requested a review from a team as a code owner January 16, 2025 10:47
Copy link
Contributor

@acsauk acsauk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andrewpearce-digital andrewpearce-digital merged commit cfe35a0 into main Jan 16, 2025
32 checks passed
@andrewpearce-digital andrewpearce-digital deleted the MLPAB-2575-crit-implement-network-firewall-for-outbound-traffic-control-from-vpc branch January 16, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants