Fix date formats #894
Open
Fix date formats #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validator was not allowing dates including leading 0s e.g. 01/01/2025. It should accept 01/01/2025 or 1/1/2025 (or any combination). The date validator uses joi which is quite rigid in how it validates date format, I considered using joi.alternatives to explicitly check against each possible format however this breaks the error messages. Therefore I opted for this solution which is unideal - it removes a leading 0 if it exists and any 0 after a / character within a string and then validates strictly against the format D/M/YYYY. So it will convert 01/01/2025 to 1/1/2025 before validating. It would also convert 01/01/07 to 1/1/7 which is invalid because of the format of the year (YYYY) anyway.