Correct reference to firewall log group #8241

dms1981 · 2024-10-10T14:49:18Z

A reference to the issue / Description of it

#7607

How does this PR fix the problem?

Incorrect CW Log Group was being applied to data stream

How has this been tested?

Tested through CI pipeline

Deployment Plan / Instructions

Deploy through CI

Checklist (check `x` in `[ ]` of list items)

I have performed a self-review of my own code
All checks have passed
I have made corresponding changes to the documentation
Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

github-actions · 2024-10-10T14:51:01Z

`Trivy Scan` Success

Show Output

```hcl

Trivy will check the following folders:
terraform/environments/core-network-services

Running Trivy in terraform/environments/core-network-services
2024-10-10T14:50:47Z INFO [vulndb] Need to update DB
2024-10-10T14:50:47Z INFO [vulndb] Downloading vulnerability DB...
2024-10-10T14:50:47Z INFO [vulndb] Downloading artifact... repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-10T14:50:50Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-10T14:50:50Z INFO [vuln] Vulnerability scanning is enabled
2024-10-10T14:50:50Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-10T14:50:50Z INFO [misconfig] Need to update the built-in checks
2024-10-10T14:50:50Z INFO [misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2024-10-10T14:50:50Z INFO [secret] Secret scanning is enabled
2024-10-10T14:50:50Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-10T14:50:50Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-10T14:50:51Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_cloudwatch_metric_alarm.nat_packets_drop_count" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_live_data_vpcs" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_noms_routes_to_firewall" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_non_live_data_vpcs" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table.external_inspection_in" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table_association.external_inspection_in" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table_association.external_inspection_out" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.external_inspection_in" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.external_inspection_out" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_ec2_transit_gateway_vpc_attachment.transit_gateway_all" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_route.live_data" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_route.non_live_data" value="cty.NilVal"
2024-10-10T14:50:51Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_firewall" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_flow_log.s3" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.inspection" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.public" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.inspection" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.public" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:11-17"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:124-129"
2024-10-10T14:50:54Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:189-193"
2024-10-10T14:50:54Z INFO Number of language-specific files num=1
2024-10-10T14:50:54Z INFO [gomod] Detecting vulnerabilities...
2024-10-10T14:50:54Z INFO Detected config files num=7
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-network-services

*****************************

Running Checkov in terraform/environments/core-network-services
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-10-10 14:50:57,094 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-chatbot?ref=73280f80ce8a4557cec3a76ee56eb913452ca9aa:None (for external modules, the --download-external-modules flag is required)
2024-10-10 14:50:57,095 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/terraform-aws-observability-platform-tenant?ref=fbbe5c8282786bcc0a00c969fe598e14f12eea9b:None (for external modules, the --download-external-modules flag is required)
2024-10-10 14:50:57,095 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=0179859e6fafc567843cd55c0b05d325d5012dc4:None (for external modules, the --download-external-modules flag is required)
2024-10-10 14:50:57,095 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=cebe39c438390ffb5355827ec9469cfe9b09c22c:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 275, Failed checks: 0, Skipped checks: 65


checkov_exitcode=0

`CTFLint Scan` Success

Show Output

*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/core-network-services

*****************************

Running tflint in terraform/environments/core-network-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

`Trivy Scan` Success

Show Output

*****************************

Trivy will check the following folders:
terraform/environments/core-network-services

*****************************

Running Trivy in terraform/environments/core-network-services
2024-10-10T14:50:47Z	INFO	[vulndb] Need to update DB
2024-10-10T14:50:47Z	INFO	[vulndb] Downloading vulnerability DB...
2024-10-10T14:50:47Z	INFO	[vulndb] Downloading artifact...	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-10T14:50:50Z	INFO	[vulndb] Artifact successfully downloaded	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-10T14:50:50Z	INFO	[vuln] Vulnerability scanning is enabled
2024-10-10T14:50:50Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-10-10T14:50:50Z	INFO	[misconfig] Need to update the built-in checks
2024-10-10T14:50:50Z	INFO	[misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2024-10-10T14:50:50Z	INFO	[secret] Secret scanning is enabled
2024-10-10T14:50:50Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-10T14:50:50Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-10T14:50:51Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_cloudwatch_metric_alarm.nat_packets_drop_count" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_live_data_vpcs" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_noms_routes_to_firewall" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_non_live_data_vpcs" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table.external_inspection_in" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table_association.external_inspection_in" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table_association.external_inspection_out" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.external_inspection_in" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.external_inspection_out" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_ec2_transit_gateway_vpc_attachment.transit_gateway_all" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_route.live_data" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_route.non_live_data" value="cty.NilVal"
2024-10-10T14:50:51Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_firewall" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_flow_log.s3" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.inspection" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.public" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.inspection" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.public" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-10T14:50:53Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:11-17"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:124-129"
2024-10-10T14:50:54Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:189-193"
2024-10-10T14:50:54Z	INFO	Number of language-specific files	num=1
2024-10-10T14:50:54Z	INFO	[gomod] Detecting vulnerabilities...
2024-10-10T14:50:54Z	INFO	Detected config files	num=7
trivy_exitcode=0

correct reference to firewall log group

f45cc31

dms1981 requested a review from a team as a code owner October 10, 2024 14:49

github-actions bot added core networking labels Oct 10, 2024

ASTRobinson approved these changes Oct 10, 2024

View reviewed changes

dms1981 added this pull request to the merge queue Oct 10, 2024

Merged via the queue into main with commit 4c9db56 Oct 10, 2024
5 checks passed

dms1981 deleted the fix/correct-firewall-loggroup branch October 10, 2024 14:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct reference to firewall log group #8241

Correct reference to firewall log group #8241

dms1981 commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

Correct reference to firewall log group #8241

Correct reference to firewall log group #8241

Conversation

dms1981 commented Oct 10, 2024

A reference to the issue / Description of it

How does this PR fix the problem?

How has this been tested?

Deployment Plan / Instructions

Checklist (check x in [ ] of list items)

Additional comments (if any)

github-actions bot commented Oct 10, 2024

Trivy Scan Success

CTFLint Scan Success

Trivy Scan Success

Checklist (check `x` in `[ ]` of list items)

`Trivy Scan` Success

`CTFLint Scan` Success

`Trivy Scan` Success