Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream firewall logs to XSIAM endpoint #8210

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Stream firewall logs to XSIAM endpoint #8210

merged 2 commits into from
Oct 8, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Oct 8, 2024

A reference to the issue / Description of it

#7607

How does this PR fix the problem?

Invokes data stream module and supplies configuration to stream logs to Palo Alto XSIAM endpoint

How has this been tested?

Tested through unit tests, but will need final confirmation from XSIAM integration team.

Deployment Plan / Instructions

Deploy through CI

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@dms1981 dms1981 requested a review from a team as a code owner October 8, 2024 14:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Trivy Scan Failed

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/core-network-services

Running Trivy in terraform/environments/core-network-services
2024-10-08T14:03:25Z INFO [vulndb] Need to update DB
2024-10-08T14:03:25Z INFO [vulndb] Downloading vulnerability DB...
2024-10-08T14:03:25Z INFO [vulndb] Downloading artifact... repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T14:03:27Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T14:03:27Z INFO [vuln] Vulnerability scanning is enabled
2024-10-08T14:03:27Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-08T14:03:27Z INFO [misconfig] Need to update the built-in checks
2024-10-08T14:03:27Z INFO [misconfig] Downloading the built-in checks...
2024-10-08T14:03:27Z ERROR [misconfig] Falling back to embedded checks err="failed to download built-in policies: download error: oci download error: failed to fetch the layer: GET https://ghcr.io/v2/aquasecurity/trivy-checks/blobs/sha256:16957b935ef82529bc26f3ceeeb60d798c90ef142d25e3715ab4478b204ed1bb: TOOMANYREQUESTS: retry-after: 1.17132ms, allowed: 44000/minute"
2024-10-08T14:03:27Z INFO [secret] Secret scanning is enabled
2024-10-08T14:03:27Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-08T14:03:27Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-08T14:03:28Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_cloudwatch_metric_alarm.nat_packets_drop_count" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_live_data_vpcs" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_noms_routes_to_firewall" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_non_live_data_vpcs" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table.external_inspection_in" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table_association.external_inspection_in" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table_association.external_inspection_out" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.external_inspection_in" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.external_inspection_out" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_ec2_transit_gateway_vpc_attachment.transit_gateway_all" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_route.live_data" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_route.non_live_data" value="cty.NilVal"
2024-10-08T14:03:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_firewall" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_flow_log.s3" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.inspection" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.public" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.inspection" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.public" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:11-17"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:124-129"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:189-193"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T14:03:31Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T14:03:31Z INFO Number of language-specific files num=1
2024-10-08T14:03:31Z INFO [gomod] Detecting vulnerabilities...
2024-10-08T14:03:31Z INFO Detected config files num=7

github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf (terraform)

Tests: 5 (SUCCESSES: 0, FAILURES: 4, EXCEPTIONS: 1)
Failures: 4 (HIGH: 4, CRITICAL: 0)

HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.

See https://avd.aquasec.com/misconfig/avd-aws-0086
────────────────────────────────────────
github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf:128-137
via logging.tf:30-35 (module.stream_firewall_logs)
────────────────────────────────────────
128 ┌ resource "aws_s3_bucket" "firehose-errors" {
129 │ # checkov:skip=CKV_AWS_18:Access logging not required
130 │ # checkov:skip=CKV_AWS_144:Replication not required
131 │ # checkov:skip=CKV_AWS_145:Standard encryption fine
132 │ # checkov:skip=CKV2_AWS_6:Bucket is private by default
133 │ # checkov:skip=CKV2_AWS_62:Notifications not necessary
134 │ bucket_prefix = "firehose-errors"
135 │ force_destroy = true
136 │ tags = var.tags
137 └ }
────────────────────────────────────────

HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.

See https://avd.aquasec.com/misconfig/avd-aws-0087
────────────────────────────────────────
github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf:128-137
via logging.tf:30-35 (module.stream_firewall_logs)
────────────────────────────────────────
128 ┌ resource "aws_s3_bucket" "firehose-errors" {
129 │ # checkov:skip=CKV_AWS_18:Access logging not required
130 │ # checkov:skip=CKV_AWS_144:Replication not required
131 │ # checkov:skip=CKV_AWS_145:Standard encryption fine
132 │ # checkov:skip=CKV2_AWS_6:Bucket is private by default
133 │ # checkov:skip=CKV2_AWS_62:Notifications not necessary
134 │ bucket_prefix = "firehose-errors"
135 │ force_destroy = true
136 │ tags = var.tags
137 └ }
────────────────────────────────────────

HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.

See https://avd.aquasec.com/misconfig/avd-aws-0091
────────────────────────────────────────
github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf:128-137
via logging.tf:30-35 (module.stream_firewall_logs)
────────────────────────────────────────
128 ┌ resource "aws_s3_bucket" "firehose-errors" {
129 │ # checkov:skip=CKV_AWS_18:Access logging not required
130 │ # checkov:skip=CKV_AWS_144:Replication not required
131 │ # checkov:skip=CKV_AWS_145:Standard encryption fine
132 │ # checkov:skip=CKV2_AWS_6:Bucket is private by default
133 │ # checkov:skip=CKV2_AWS_62:Notifications not necessary
134 │ bucket_prefix = "firehose-errors"
135 │ force_destroy = true
136 │ tags = var.tags
137 └ }
────────────────────────────────────────

HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.

See https://avd.aquasec.com/misconfig/avd-aws-0093
────────────────────────────────────────
github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf:128-137
via logging.tf:30-35 (module.stream_firewall_logs)
────────────────────────────────────────
128 ┌ resource "aws_s3_bucket" "firehose-errors" {
129 │ # checkov:skip=CKV_AWS_18:Access logging not required
130 │ # checkov:skip=CKV_AWS_144:Replication not required
131 │ # checkov:skip=CKV_AWS_145:Standard encryption fine
132 │ # checkov:skip=CKV2_AWS_6:Bucket is private by default
133 │ # checkov:skip=CKV2_AWS_62:Notifications not necessary
134 │ bucket_prefix = "firehose-errors"
135 │ force_destroy = true
136 │ tags = var.tags
137 └ }
────────────────────────────────────────

trivy_exitcode=1

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-network-services

*****************************

Running Checkov in terraform/environments/core-network-services
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-10-08 14:03:33,948 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=0179859e6fafc567843cd55c0b05d325d5012dc4:None (for external modules, the --download-external-modules flag is required)
2024-10-08 14:03:33,948 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3:None (for external modules, the --download-external-modules flag is required)
2024-10-08 14:03:33,948 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/terraform-aws-observability-platform-tenant?ref=fbbe5c8282786bcc0a00c969fe598e14f12eea9b:None (for external modules, the --download-external-modules flag is required)
2024-10-08 14:03:33,948 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-chatbot?ref=73280f80ce8a4557cec3a76ee56eb913452ca9aa:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 275, Failed checks: 0, Skipped checks: 65


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/core-network-services

*****************************

Running tflint in terraform/environments/core-network-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Failed

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/core-network-services

*****************************

Running Trivy in terraform/environments/core-network-services
2024-10-08T14:03:25Z	INFO	[vulndb] Need to update DB
2024-10-08T14:03:25Z	INFO	[vulndb] Downloading vulnerability DB...
2024-10-08T14:03:25Z	INFO	[vulndb] Downloading artifact...	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T14:03:27Z	INFO	[vulndb] Artifact successfully downloaded	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T14:03:27Z	INFO	[vuln] Vulnerability scanning is enabled
2024-10-08T14:03:27Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-10-08T14:03:27Z	INFO	[misconfig] Need to update the built-in checks
2024-10-08T14:03:27Z	INFO	[misconfig] Downloading the built-in checks...
2024-10-08T14:03:27Z	ERROR	[misconfig] Falling back to embedded checks	err="failed to download built-in policies: download error: oci download error: failed to fetch the layer: GET https://ghcr.io/v2/aquasecurity/trivy-checks/blobs/sha256:16957b935ef82529bc26f3ceeeb60d798c90ef142d25e3715ab4478b204ed1bb: TOOMANYREQUESTS: retry-after: 1.17132ms, allowed: 44000/minute"
2024-10-08T14:03:27Z	INFO	[secret] Secret scanning is enabled
2024-10-08T14:03:27Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-08T14:03:27Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-08T14:03:28Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_cloudwatch_metric_alarm.nat_packets_drop_count" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_live_data_vpcs" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_noms_routes_to_firewall" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_non_live_data_vpcs" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table.external_inspection_in" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table_association.external_inspection_in" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table_association.external_inspection_out" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.external_inspection_in" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.external_inspection_out" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_ec2_transit_gateway_vpc_attachment.transit_gateway_all" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_route.live_data" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_route.non_live_data" value="cty.NilVal"
2024-10-08T14:03:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_firewall" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_flow_log.s3" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.inspection" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.public" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.inspection" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.public" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-08T14:03:30Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:11-17"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:124-129"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:189-193"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T14:03:31Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T14:03:31Z	INFO	Number of language-specific files	num=1
2024-10-08T14:03:31Z	INFO	[gomod] Detecting vulnerabilities...
2024-10-08T14:03:31Z	INFO	Detected config files	num=7

github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf (terraform)
================================================================================================================================================
Tests: 5 (SUCCESSES: 0, FAILURES: 4, EXCEPTIONS: 1)
Failures: 4 (HIGH: 4, CRITICAL: 0)

HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should block public ACLs on buckets and any objects they contain. By blocking, PUTs with fail if the object has any public ACL a.


See https://avd.aquasec.com/misconfig/avd-aws-0086
────────────────────────────────────────
 github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf:128-137
   via logging.tf:30-35 (module.stream_firewall_logs)
────────────────────────────────────────
 128 ┌ resource "aws_s3_bucket" "firehose-errors" {
 129 │   # checkov:skip=CKV_AWS_18:Access logging not required
 130 │   # checkov:skip=CKV_AWS_144:Replication not required
 131 │   # checkov:skip=CKV_AWS_145:Standard encryption fine
 132 │   # checkov:skip=CKV2_AWS_6:Bucket is private by default
 133 │   # checkov:skip=CKV2_AWS_62:Notifications not necessary
 134 │   bucket_prefix = "firehose-errors"
 135 │   force_destroy = true
 136 │   tags          = var.tags
 137 └ }
────────────────────────────────────────


HIGH: No public access block so not blocking public policies
════════════════════════════════════════
S3 bucket policy should have block public policy to prevent users from putting a policy that enable public access.


See https://avd.aquasec.com/misconfig/avd-aws-0087
────────────────────────────────────────
 github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf:128-137
   via logging.tf:30-35 (module.stream_firewall_logs)
────────────────────────────────────────
 128 ┌ resource "aws_s3_bucket" "firehose-errors" {
 129 │   # checkov:skip=CKV_AWS_18:Access logging not required
 130 │   # checkov:skip=CKV_AWS_144:Replication not required
 131 │   # checkov:skip=CKV_AWS_145:Standard encryption fine
 132 │   # checkov:skip=CKV2_AWS_6:Bucket is private by default
 133 │   # checkov:skip=CKV2_AWS_62:Notifications not necessary
 134 │   bucket_prefix = "firehose-errors"
 135 │   force_destroy = true
 136 │   tags          = var.tags
 137 └ }
────────────────────────────────────────


HIGH: No public access block so not blocking public acls
════════════════════════════════════════
S3 buckets should ignore public ACLs on buckets and any objects they contain. By ignoring rather than blocking, PUT calls with public ACLs will still be applied but the ACL will be ignored.


See https://avd.aquasec.com/misconfig/avd-aws-0091
────────────────────────────────────────
 github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf:128-137
   via logging.tf:30-35 (module.stream_firewall_logs)
────────────────────────────────────────
 128 ┌ resource "aws_s3_bucket" "firehose-errors" {
 129 │   # checkov:skip=CKV_AWS_18:Access logging not required
 130 │   # checkov:skip=CKV_AWS_144:Replication not required
 131 │   # checkov:skip=CKV_AWS_145:Standard encryption fine
 132 │   # checkov:skip=CKV2_AWS_6:Bucket is private by default
 133 │   # checkov:skip=CKV2_AWS_62:Notifications not necessary
 134 │   bucket_prefix = "firehose-errors"
 135 │   force_destroy = true
 136 │   tags          = var.tags
 137 └ }
────────────────────────────────────────


HIGH: No public access block so not restricting public buckets
════════════════════════════════════════
S3 buckets should restrict public policies for the bucket. By enabling, the restrict_public_buckets, only the bucket owner and AWS Services can access if it has a public policy.


See https://avd.aquasec.com/misconfig/avd-aws-0093
────────────────────────────────────────
 github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=fe5220c39053d52e33ef6feeec0245d65a8157f3/main.tf:128-137
   via logging.tf:30-35 (module.stream_firewall_logs)
────────────────────────────────────────
 128 ┌ resource "aws_s3_bucket" "firehose-errors" {
 129 │   # checkov:skip=CKV_AWS_18:Access logging not required
 130 │   # checkov:skip=CKV_AWS_144:Replication not required
 131 │   # checkov:skip=CKV_AWS_145:Standard encryption fine
 132 │   # checkov:skip=CKV2_AWS_6:Bucket is private by default
 133 │   # checkov:skip=CKV2_AWS_62:Notifications not necessary
 134 │   bucket_prefix = "firehose-errors"
 135 │   force_destroy = true
 136 │   tags          = var.tags
 137 └ }
────────────────────────────────────────


trivy_exitcode=1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/core-network-services

Running Trivy in terraform/environments/core-network-services
2024-10-08T16:09:21Z INFO [vulndb] Need to update DB
2024-10-08T16:09:21Z INFO [vulndb] Downloading vulnerability DB...
2024-10-08T16:09:21Z INFO [vulndb] Downloading artifact... repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T16:09:23Z INFO [vulndb] Artifact successfully downloaded repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T16:09:23Z INFO [vuln] Vulnerability scanning is enabled
2024-10-08T16:09:23Z INFO [misconfig] Misconfiguration scanning is enabled
2024-10-08T16:09:23Z INFO [misconfig] Need to update the built-in checks
2024-10-08T16:09:23Z INFO [misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2024-10-08T16:09:24Z INFO [secret] Secret scanning is enabled
2024-10-08T16:09:24Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-08T16:09:24Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-08T16:09:25Z INFO [terraform scanner] Scanning root module file_path="."
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_cloudwatch_metric_alarm.nat_packets_drop_count" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_live_data_vpcs" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_noms_routes_to_firewall" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_non_live_data_vpcs" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table.external_inspection_in" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table_association.external_inspection_in" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_route_table_association.external_inspection_out" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.external_inspection_in" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.external_inspection_out" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_ec2_transit_gateway_vpc_attachment.transit_gateway_all" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_route.live_data" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="data.aws_route.non_live_data" value="cty.NilVal"
2024-10-08T16:09:25Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_ec2_transit_gateway_route_table_propagation.propagate_firewall" value="cty.NilVal"
2024-10-08T16:09:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-08T16:09:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-08T16:09:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-08T16:09:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-08T16:09:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-08T16:09:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-08T16:09:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-08T16:09:27Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_flow_log.s3" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.inspection" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.public" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["live_data"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.inspection" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.public" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="module.vpc_inspection["non_live_data"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:11-17"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:124-129"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="monitoring.tf:189-193"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-08T16:09:29Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-08T16:09:29Z INFO Number of language-specific files num=1
2024-10-08T16:09:29Z INFO [gomod] Detecting vulnerabilities...
2024-10-08T16:09:29Z INFO Detected config files num=7
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-network-services

*****************************

Running Checkov in terraform/environments/core-network-services
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-10-08 16:09:32,001 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=0179859e6fafc567843cd55c0b05d325d5012dc4:None (for external modules, the --download-external-modules flag is required)
2024-10-08 16:09:32,002 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=cebe39c438390ffb5355827ec9469cfe9b09c22c:None (for external modules, the --download-external-modules flag is required)
2024-10-08 16:09:32,002 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/terraform-aws-observability-platform-tenant?ref=fbbe5c8282786bcc0a00c969fe598e14f12eea9b:None (for external modules, the --download-external-modules flag is required)
2024-10-08 16:09:32,002 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-aws-chatbot?ref=73280f80ce8a4557cec3a76ee56eb913452ca9aa:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 275, Failed checks: 0, Skipped checks: 65


checkov_exitcode=0

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/core-network-services

*****************************

Running tflint in terraform/environments/core-network-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/core-network-services

*****************************

Running Trivy in terraform/environments/core-network-services
2024-10-08T16:09:21Z	INFO	[vulndb] Need to update DB
2024-10-08T16:09:21Z	INFO	[vulndb] Downloading vulnerability DB...
2024-10-08T16:09:21Z	INFO	[vulndb] Downloading artifact...	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T16:09:23Z	INFO	[vulndb] Artifact successfully downloaded	repo="ghcr.io/aquasecurity/trivy-db:2"
2024-10-08T16:09:23Z	INFO	[vuln] Vulnerability scanning is enabled
2024-10-08T16:09:23Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-10-08T16:09:23Z	INFO	[misconfig] Need to update the built-in checks
2024-10-08T16:09:23Z	INFO	[misconfig] Downloading the built-in checks...
156.02 KiB / 156.02 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2024-10-08T16:09:24Z	INFO	[secret] Secret scanning is enabled
2024-10-08T16:09:24Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-10-08T16:09:24Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.56/docs/scanner/secret#recommendation for faster secret detection
2024-10-08T16:09:25Z	INFO	[terraform scanner] Scanning root module	file_path="."
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_cloudwatch_metric_alarm.nat_packets_drop_count" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_live_data_vpcs" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_noms_routes_to_firewall" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_non_live_data_vpcs" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table.external_inspection_in" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table_association.external_inspection_in" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_route_table_association.external_inspection_out" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.external_inspection_in" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.external_inspection_out" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_ec2_transit_gateway_vpc_attachment.transit_gateway_all" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_route.live_data" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="data.aws_route.non_live_data" value="cty.NilVal"
2024-10-08T16:09:25Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_ec2_transit_gateway_route_table_propagation.propagate_firewall" value="cty.NilVal"
2024-10-08T16:09:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-08T16:09:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-08T16:09:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-08T16:09:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.ip_sets" value="cty.NilVal"
2024-10-08T16:09:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.port_sets" value="cty.NilVal"
2024-10-08T16:09:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.firewall_policy.dynamic.rule_variables" value="cty.NilVal"
2024-10-08T16:09:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-08T16:09:27Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.stream_firewall_logs.dynamic.http_endpoint_configuration" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_flow_log.s3" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.inspection" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.public" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"live_data\"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.inspection" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.public" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_subnet.transit-gateway" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-0-0-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-20-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-231-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-26-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.inspection-10-27-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-0-0-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-20-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-231-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-26-0-0" value="cty.NilVal"
2024-10-08T16:09:28Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="module.vpc_inspection[\"non_live_data\"].aws_route.public-10-27-0-0" value="cty.NilVal"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:11-17"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:124-129"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="monitoring.tf:189-193"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:184"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:278"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="../../modules/vpc-inspection/main.tf:376"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-cloudwatch-log-group-customer-key" range="../../modules/firewall-logging/main.tf:21-26"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:186"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:280"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-08T16:09:29Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-ingress-acl" range="../../modules/vpc-inspection/main.tf:378"
2024-10-08T16:09:29Z	INFO	Number of language-specific files	num=1
2024-10-08T16:09:29Z	INFO	[gomod] Detecting vulnerabilities...
2024-10-08T16:09:29Z	INFO	Detected config files	num=7
trivy_exitcode=0

@dms1981 dms1981 added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 3608615 Oct 8, 2024
5 checks passed
@dms1981 dms1981 deleted the feature/7607-stream-firewall-logs branch October 8, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASTRobinson ASTRobinson ASTRobinson approved these changes

Assignees
No one assigned
Labels
core networking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dms1981 @ASTRobinson