-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to insecure_value for nonsensitive values #8120
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
A reference to the issue / Description of it
#7607
How does this PR fix the problem?
SSM Parameter Store was chosen specifically to hold parameters that don't need special handling. This PR swaps from
value
toinsecure_value
to address this. The alternative - wrapping outputs asnonsecure()
would achieve the same thing, so to make the correct handling of these values clear I've chosen to switch the attributes used.How has this been tested?
Tested with local plan and through CI pipeline
Deployment Plan / Instructions
Deploy through CI
Checklist (check
x
in[ ]
of list items)Additional comments (if any)
{Please write here}