Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XSIAM housekeeping #7799

Merged
merged 5 commits into from
Aug 29, 2024
Merged

XSIAM housekeeping #7799

merged 5 commits into from
Aug 29, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Aug 29, 2024

A reference to the issue / Description of it

#7607

How does this PR fix the problem?

Housekeeping to reduce the scope of configuration items for Cortex XSIAM use.

How has this been tested?

Tested with local plan / manual console changes

Deployment Plan / Instructions

Deploy through CI

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@dms1981 dms1981 requested a review from a team as a code owner August 29, 2024 13:18
@github-actions github-actions bot added the core label Aug 29, 2024
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/core-logging


Running Trivy in terraform/environments/core-logging
2024-08-29T13:20:30Z INFO [db] Need to update DB
2024-08-29T13:20:30Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-29T13:20:32Z INFO [vuln] Vulnerability scanning is enabled
2024-08-29T13:20:32Z INFO [misconfig] Misconfiguration scanning is enabled
2024-08-29T13:20:32Z INFO Need to update the built-in policies
2024-08-29T13:20:32Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-29T13:20:33Z INFO [secret] Secret scanning is enabled
2024-08-29T13:20:33Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-29T13:20:33Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-29T13:20:35Z INFO Number of language-specific files num=1
2024-08-29T13:20:35Z INFO [gomod] Detecting vulnerabilities...
2024-08-29T13:20:35Z INFO Detected config files num=10
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-logging

*****************************

Running Checkov in terraform/environments/core-logging
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2024-08-29 13:20:38,099 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1:None (for external modules, the --download-external-modules flag is required)
2024-08-29 13:20:38,099 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=cadab519b10a7d28dfa3b77d407725db6b37614a:None (for external modules, the --download-external-modules flag is required)
2024-08-29 13:20:38,099 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/terraform-aws-observability-platform-tenant?ref=fbbe5c8282786bcc0a00c969fe598e14f12eea9b:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 563, Failed checks: 0, Skipped checks: 205


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/core-logging

*****************************

Running tflint in terraform/environments/core-logging
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/core-logging

*****************************

Running Trivy in terraform/environments/core-logging
2024-08-29T13:20:30Z	INFO	[db] Need to update DB
2024-08-29T13:20:30Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-29T13:20:32Z	INFO	[vuln] Vulnerability scanning is enabled
2024-08-29T13:20:32Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-08-29T13:20:32Z	INFO	Need to update the built-in policies
2024-08-29T13:20:32Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-29T13:20:33Z	INFO	[secret] Secret scanning is enabled
2024-08-29T13:20:33Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-29T13:20:33Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-29T13:20:35Z	INFO	Number of language-specific files	num=1
2024-08-29T13:20:35Z	INFO	[gomod] Detecting vulnerabilities...
2024-08-29T13:20:35Z	INFO	Detected config files	num=10
trivy_exitcode=0

Copy link
Contributor

@markgov markgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dms1981 dms1981 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 87c03ca Aug 29, 2024
5 checks passed
@dms1981 dms1981 deleted the fix/7607-housekeeping branch August 29, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants