Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dso/dsos 2903/pagerduty alarm improvement #7729

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

robertsweetman
Copy link
Contributor

A reference to the issue / Description of it

Refactoring pagerduty integrations to allow users to more quickly understand where/what is alarm(ing)

How does this PR fix the problem?

Start making changes in CSR env and will tie in to sns topic changes in mod-platform-environments repo

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

Initially just want the terraform to work and see the services etc. being created in the PagerDuty backend

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

No

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@robertsweetman robertsweetman requested a review from a team as a code owner August 20, 2024 15:05
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty


Running Trivy in terraform/pagerduty
2024-08-20T15:07:52Z INFO [db] Need to update DB
2024-08-20T15:07:52Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:07:54Z INFO [vuln] Vulnerability scanning is enabled
2024-08-20T15:07:54Z INFO [misconfig] Misconfiguration scanning is enabled
2024-08-20T15:07:54Z INFO Need to update the built-in policies
2024-08-20T15:07:54Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:07:54Z INFO [secret] Secret scanning is enabled
2024-08-20T15:07:54Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:07:54Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:07:55Z INFO Number of language-specific files num=0
2024-08-20T15:07:55Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-08-20T15:07:52Z	INFO	[db] Need to update DB
2024-08-20T15:07:52Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:07:54Z	INFO	[vuln] Vulnerability scanning is enabled
2024-08-20T15:07:54Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-08-20T15:07:54Z	INFO	Need to update the built-in policies
2024-08-20T15:07:54Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:07:54Z	INFO	[secret] Secret scanning is enabled
2024-08-20T15:07:54Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:07:54Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:07:55Z	INFO	Number of language-specific files	num=0
2024-08-20T15:07:55Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty


Running Trivy in terraform/pagerduty
2024-08-20T15:14:10Z INFO [db] Need to update DB
2024-08-20T15:14:10Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:14:12Z INFO [vuln] Vulnerability scanning is enabled
2024-08-20T15:14:12Z INFO [misconfig] Misconfiguration scanning is enabled
2024-08-20T15:14:12Z INFO Need to update the built-in policies
2024-08-20T15:14:12Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:14:13Z INFO [secret] Secret scanning is enabled
2024-08-20T15:14:13Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:14:13Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:14:13Z INFO Number of language-specific files num=0
2024-08-20T15:14:13Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-08-20T15:14:10Z	INFO	[db] Need to update DB
2024-08-20T15:14:10Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:14:12Z	INFO	[vuln] Vulnerability scanning is enabled
2024-08-20T15:14:12Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-08-20T15:14:12Z	INFO	Need to update the built-in policies
2024-08-20T15:14:12Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:14:13Z	INFO	[secret] Secret scanning is enabled
2024-08-20T15:14:13Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:14:13Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:14:13Z	INFO	Number of language-specific files	num=0
2024-08-20T15:14:13Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty


Running Trivy in terraform/pagerduty
2024-08-20T15:17:28Z INFO [db] Need to update DB
2024-08-20T15:17:28Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:17:30Z INFO [vuln] Vulnerability scanning is enabled
2024-08-20T15:17:30Z INFO [misconfig] Misconfiguration scanning is enabled
2024-08-20T15:17:30Z INFO Need to update the built-in policies
2024-08-20T15:17:30Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:17:30Z INFO [secret] Secret scanning is enabled
2024-08-20T15:17:30Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:17:30Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:17:31Z INFO Number of language-specific files num=0
2024-08-20T15:17:31Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
1 issue(s) found:

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/pagerduty/member-services-integrations.tf line 2597:
2597:   name                    = "${each.key}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

tflint_exitcode=2

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-08-20T15:17:28Z	INFO	[db] Need to update DB
2024-08-20T15:17:28Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:17:30Z	INFO	[vuln] Vulnerability scanning is enabled
2024-08-20T15:17:30Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-08-20T15:17:30Z	INFO	Need to update the built-in policies
2024-08-20T15:17:30Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:17:30Z	INFO	[secret] Secret scanning is enabled
2024-08-20T15:17:30Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:17:30Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:17:31Z	INFO	Number of language-specific files	num=0
2024-08-20T15:17:31Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty


Running Trivy in terraform/pagerduty
2024-08-20T15:21:37Z INFO [db] Need to update DB
2024-08-20T15:21:37Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:21:39Z INFO [vuln] Vulnerability scanning is enabled
2024-08-20T15:21:39Z INFO [misconfig] Misconfiguration scanning is enabled
2024-08-20T15:21:39Z INFO Need to update the built-in policies
2024-08-20T15:21:39Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:21:39Z INFO [secret] Secret scanning is enabled
2024-08-20T15:21:39Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:21:39Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:21:40Z INFO Number of language-specific files num=0
2024-08-20T15:21:40Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
1 issue(s) found:

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/pagerduty/member-services-integrations.tf line 2597:
2597:   name                    = "${each.key}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

tflint_exitcode=2

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-08-20T15:21:37Z	INFO	[db] Need to update DB
2024-08-20T15:21:37Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:21:39Z	INFO	[vuln] Vulnerability scanning is enabled
2024-08-20T15:21:39Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-08-20T15:21:39Z	INFO	Need to update the built-in policies
2024-08-20T15:21:39Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:21:39Z	INFO	[secret] Secret scanning is enabled
2024-08-20T15:21:39Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:21:39Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:21:40Z	INFO	Number of language-specific files	num=0
2024-08-20T15:21:40Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty


Running Trivy in terraform/pagerduty
2024-08-20T15:28:22Z INFO [db] Need to update DB
2024-08-20T15:28:22Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:28:25Z INFO [vuln] Vulnerability scanning is enabled
2024-08-20T15:28:25Z INFO [misconfig] Misconfiguration scanning is enabled
2024-08-20T15:28:25Z INFO Need to update the built-in policies
2024-08-20T15:28:25Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:28:25Z INFO [secret] Secret scanning is enabled
2024-08-20T15:28:25Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:28:25Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:28:25Z INFO Number of language-specific files num=0
2024-08-20T15:28:25Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
1 issue(s) found:

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/pagerduty/member-services-integrations.tf line 2597:
2597:   name                    = "${each.key}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

tflint_exitcode=2

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-08-20T15:28:22Z	INFO	[db] Need to update DB
2024-08-20T15:28:22Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:28:25Z	INFO	[vuln] Vulnerability scanning is enabled
2024-08-20T15:28:25Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-08-20T15:28:25Z	INFO	Need to update the built-in policies
2024-08-20T15:28:25Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:28:25Z	INFO	[secret] Secret scanning is enabled
2024-08-20T15:28:25Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:28:25Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:28:25Z	INFO	Number of language-specific files	num=0
2024-08-20T15:28:25Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty


Running Trivy in terraform/pagerduty
2024-08-20T15:32:31Z INFO [db] Need to update DB
2024-08-20T15:32:31Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:32:33Z INFO [vuln] Vulnerability scanning is enabled
2024-08-20T15:32:33Z INFO [misconfig] Misconfiguration scanning is enabled
2024-08-20T15:32:33Z INFO Need to update the built-in policies
2024-08-20T15:32:33Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:32:33Z INFO [secret] Secret scanning is enabled
2024-08-20T15:32:33Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:32:33Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:32:34Z INFO Number of language-specific files num=0
2024-08-20T15:32:34Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Failed

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
1 issue(s) found:

Warning: [Fixable] Interpolation-only expressions are deprecated in Terraform v0.12.14 (terraform_deprecated_interpolation)

  on terraform/pagerduty/member-services-integrations.tf line 2597:
2597:   name                    = "${each.key}"

Reference: https://github.com/terraform-linters/tflint-ruleset-terraform/blob/v0.5.0/docs/rules/terraform_deprecated_interpolation.md

tflint_exitcode=2

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-08-20T15:32:31Z	INFO	[db] Need to update DB
2024-08-20T15:32:31Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:32:33Z	INFO	[vuln] Vulnerability scanning is enabled
2024-08-20T15:32:33Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-08-20T15:32:33Z	INFO	Need to update the built-in policies
2024-08-20T15:32:33Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:32:33Z	INFO	[secret] Secret scanning is enabled
2024-08-20T15:32:33Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:32:33Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:32:34Z	INFO	Number of language-specific files	num=0
2024-08-20T15:32:34Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty


Running Trivy in terraform/pagerduty
2024-08-20T15:56:48Z INFO [db] Need to update DB
2024-08-20T15:56:48Z INFO [db] Downloading DB... repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:56:50Z INFO [vuln] Vulnerability scanning is enabled
2024-08-20T15:56:50Z INFO [misconfig] Misconfiguration scanning is enabled
2024-08-20T15:56:50Z INFO Need to update the built-in policies
2024-08-20T15:56:50Z INFO Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:56:51Z INFO [secret] Secret scanning is enabled
2024-08-20T15:56:51Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:56:51Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:56:51Z INFO Number of language-specific files num=0
2024-08-20T15:56:51Z INFO Detected config files num=3
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 27, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2024-08-20T15:56:48Z	INFO	[db] Need to update DB
2024-08-20T15:56:48Z	INFO	[db] Downloading DB...	repository="ghcr.io/aquasecurity/trivy-db:2"
2024-08-20T15:56:50Z	INFO	[vuln] Vulnerability scanning is enabled
2024-08-20T15:56:50Z	INFO	[misconfig] Misconfiguration scanning is enabled
2024-08-20T15:56:50Z	INFO	Need to update the built-in policies
2024-08-20T15:56:50Z	INFO	Downloading the built-in policies...
74.86 KiB / 74.86 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s2024-08-20T15:56:51Z	INFO	[secret] Secret scanning is enabled
2024-08-20T15:56:51Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-08-20T15:56:51Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.54/docs/scanner/secret#recommendation for faster secret detection
2024-08-20T15:56:51Z	INFO	Number of language-specific files	num=0
2024-08-20T15:56:51Z	INFO	Detected config files	num=3
trivy_exitcode=0

Copy link
Contributor

@Kudzai-moj Kudzai-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsweetman robertsweetman added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 54ca28a Aug 20, 2024
5 checks passed
@robertsweetman robertsweetman deleted the DSO/DSOS-2903/pagerduty-alarm-improvement branch August 20, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants