Merge pull request #8005 from ministryofjustice/feature/7607-remove-l…

…ogs-via-firehose Remove config to send `core-network-services` flow logs via data firehose
ministryofjustice · Sep 23, 2024 · 873e98f · 873e98f
2 parents 13aa841 + 12c5154
commit 873e98f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/terraform/environments/core-network-services/locals.tf b/terraform/environments/core-network-services/locals.tf
@@ -17,7 +17,6 @@ locals {
   xsiam                          = jsondecode(data.aws_secretsmanager_secret_version.xsiam_secret_arn_version.secret_string)
   cloudwatch_log_buckets         = jsondecode(data.aws_secretsmanager_secret_version.core_logging_bucket_arns.secret_string)
   cloudwatch_generic_log_groups  = concat([module.firewall_logging.cloudwatch_log_group_name], [for key, value in module.vpc_inspection : value.fw_cloudwatch_name])
-  cloudwatch_vpc_flow_log_groups = concat([aws_cloudwatch_log_group.external_inspection.name, aws_cloudwatch_log_group.tgw_flowlog_group.name], [for key, value in module.vpc_inspection : value.vpc_cloudwatch_name])
 
   tags = {
     business-unit = "Platforms"

diff --git a/terraform/environments/core-network-services/logging.tf b/terraform/environments/core-network-services/logging.tf
@@ -1,11 +1,3 @@
-module "logging-vpc-flow-logs" {
-  source                     = "github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=2e58c8fd0b43ca8461dfd0c8cc5f43a1a9c49987" #v1.1.0
-  for_each                   = local.is-production ? { "build" = true } : {}
-  cloudwatch_log_group_names = local.cloudwatch_vpc_flow_log_groups
-  destination_bucket_arn     = local.cloudwatch_log_buckets["vpc-flow-logs"]
-  tags                       = local.tags
-}
-
 module "logging-generic-logs" {
   source                     = "github.com/ministryofjustice/modernisation-platform-terraform-aws-data-firehose?ref=2e58c8fd0b43ca8461dfd0c8cc5f43a1a9c49987" #v1.1.0
   for_each                   = local.is-production ? { "build" = true } : {}