Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass at addressing SCA checks #31

Merged
merged 2 commits into from
Oct 8, 2024
Merged

First pass at addressing SCA checks #31

merged 2 commits into from
Oct 8, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Oct 8, 2024

Skipped some SCA checks, addressed others with supplementary resources.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:

@dms1981
Copy link
Contributor Author

dms1981 commented Oct 8, 2024

Tracked upstream in ministryofjustice/modernisation-platform#7607

@dms1981 dms1981 marked this pull request as ready for review October 8, 2024 11:26
@dms1981 dms1981 requested a review from a team as a code owner October 8, 2024 11:26
Khatraf
Khatraf approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Khatraf Khatraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dms1981 dms1981 merged commit fe5220c into main Oct 8, 2024
@dms1981 dms1981 deleted the fix/sca-alerts branch October 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khatraf Khatraf Khatraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dms1981 @Khatraf