Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5701: PLF proceeding loop limit #7604

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

AP-5701: PLF proceeding loop limit #7604

wants to merge 6 commits into from

Conversation

colinbruce
Copy link
Contributor

What

Link to story

Limit the ability to proceed if the provider has chosen all applicable proceedings

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-5701/plf-proceeding-loop-limit branch from 4a4330f to 84c294c Compare January 31, 2025 15:48
@colinbruce
AP-5621: Remove fixed width of means report print style
08f05a0 
The fixed width caused the lines and data to overflow when
generating Means and Merits reports.  This is a minimal fix

There was conversation about reviewing the entire print CSS
handling, but this ticket is just to address the overruns
@colinbruce
AP-5701: Update LFA filter service to raise an error when nothing found
562920d 
This is needed for PLF non means tested but may hit more
matter types in the future
@colinbruce
AP-5701: Update HasOtherProceedingsForm with remaining_proceedings me…
cb573d3 
…thod

This will be used on the view to define logic on
when to show and hide text values
@colinbruce
AP-5701: Update has_other_proceedings controller
bed9afe 
Update the view to display the correct text if all four
proceedings have been chosen.  Update the controller tests
to ensure it works.  Record new VCR cassettes as we have to
make an additional call to the LFA endpoint
@colinbruce
AP-5701: Update proceeding_types controller
8d15ae7 
If no proceedings are found, redirect to the has_other_proceedings page

This should avoid a user pushing the back button and arriving at a page that
cannot be displayed because there are no proceedings to choose from
@colinbruce
AP=5701: Re-record cassettes for new LFA interactions
e29d8ae
@colinbruce colinbruce force-pushed the ap-5701/plf-proceeding-loop-limit branch from 4d9c745 to e29d8ae Compare January 31, 2025 16:39
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@colinbruce