Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4774: Fix accessibility issues with hidden labels #6292

Merged

Conversation

agoldstone93
Copy link
Contributor

What

Link to story

Remove instances of visually hidden text, that is read out with a screenreader, which duplicates visual text

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the ap-4774-fix-accessibility-issues-with-hidden-labels branch 2 times, most recently from ff79e0d to 34aa88d Compare January 30, 2024 14:09
@agoldstone93 agoldstone93 marked this pull request as ready for review January 31, 2024 12:04
@agoldstone93 agoldstone93 requested a review from a team as a code owner January 31, 2024 12:04
@naseberry
Copy link
Contributor

Only one question.

Good work CYC-ing list_from_translation_path and removing those spacing divs

Remove use of bullet point helper method as unnecessary
Remove padding as no need to override
@agoldstone93 agoldstone93 force-pushed the ap-4774-fix-accessibility-issues-with-hidden-labels branch from 34aa88d to 1976d62 Compare February 1, 2024 14:17
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@agoldstone93 agoldstone93 merged commit 2d44cfd into main Feb 1, 2024
14 checks passed
@agoldstone93 agoldstone93 deleted the ap-4774-fix-accessibility-issues-with-hidden-labels branch February 1, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants