Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4327: Partner means fixes #6238

Merged
merged 2 commits into from
Jan 17, 2024
Merged

AP-4327: Partner means fixes #6238

merged 2 commits into from
Jan 17, 2024

Conversation

colinbruce
Copy link
Contributor

What

Link to story

Improve the means report handling of partner disregarded_state_benefits
Improve the flow around outgoings for partners

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

There was a missing flow step when an applicant has a partner
but has no outgoings
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@colinbruce colinbruce added the ready for review Please review label Jan 17, 2024
@colinbruce colinbruce marked this pull request as ready for review January 17, 2024 12:33
@colinbruce colinbruce requested a review from a team as a code owner January 17, 2024 12:34
Copy link
Contributor

@skdejong skdejong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naseberry
Copy link
Contributor

Ready to go 👍

@colinbruce colinbruce merged commit b4ea86a into main Jan 17, 2024
6 checks passed
@colinbruce colinbruce deleted the ap-4327/partner-fixes branch January 17, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants