AP-2095 remove respondent-details.js #2355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Link to story
Removed file respondent-details.js.
This file contained code for updated the labels and showing the revealed fields and errors of conditionally revealing radio buttons on the police notified details question.
This is no longer needed as all happens automatically since the page was updated with the new formbuilder.
NOTE:
The label updates in the JS were used in conjunction with the aria-expanded attribute to notify users of conditionally revealed content. The current design system recommendation is not to use the aria-expanded attribute, as it is not an allowed aria-attribute and therefore is often missed by screen readers anyway, and so the new formbuilder does not implement aria-expanded on conditional radio buttons.
Notifying screen readers of revealed content in radio buttons is still an issue which is not fixed in the design system, but there is a planned fix for the end of March 2021: alphagov/govuk-frontend#979
Checklist
Before you ask people to review this PR:
bundle exec rake
git rebase master
.