Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove “Closed” tag from closed non-association view page #199

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Remove “Closed” tag from closed non-association view page #199

merged 2 commits into from
Nov 6, 2023

Conversation

ushkarev
Copy link
Contributor

@ushkarev ushkarev commented Nov 5, 2023 •
edited
Loading

No description provided.

@ushkarev ushkarev requested a review from a team as a code owner November 5, 2023 13:52
@ushkarev
Copy link
Contributor Author

ushkarev commented Nov 5, 2023

i think this will make it harder to notice when a non-association is closed :(

xoen
xoen approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@xoen xoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

However, I think the tag made the page more usable as the user could tell at a glance whether a non-association was closed.

@ushkarev ushkarev merged commit fa14416 into main Nov 6, 2023
@ushkarev ushkarev deleted the no-closed-tag branch November 6, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xoen xoen xoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ushkarev @xoen