ADJUST1-452 DR Edit remand #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,4 +19,31 @@ export default class RemandChangeModel { | |||
| public remandRelatedValidationSummary() { | |||
| return remandRelatedValidationSummary(this.calculatedUnusedDeductions?.validationMessages) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
ideally we try and use more functional programming techniques in modern typescript, e.g. moving away from using traditional for loops and mutable variables.. something like this.
public isModified(): boolean {
if (!this.dbAdjustment) {
return false;
}
const sessionCharges = this.adjustment.remand.chargeId.sort((a, b) => a - b);
const dbCharges = this.dbAdjustment.remand.chargeId.sort((a, b) => a - b);
const chargeIdModified = !sessionCharges.every((chargeId, index) => chargeId === dbCharges[index]);
const dateModified = this.adjustment.toDate !== this.dbAdjustment.toDate ||
this.adjustment.fromDate !== this.dbAdjustment.fromDate;
return chargeIdModified || dateModified;
}
There was a problem hiding this comment.
I've adjusted this as you've suggested
| {% if model.showUnusedMessage %} | ||
| <p class="govuk-body">The updates will change the amount of unused deductions. Check the unused remand alert on NOMIS.</p> | ||
| {% endif %} | ||
|
|
||
| <form method="post"> | ||
| <input type="hidden" name="_csrf" value="{{ csrfToken }}"/> | ||
| <div class="govuk-button-group"> | ||
| {% if not model.remandRelatedValidationSummary().errorList.length %} | ||
| {% if not model.remandRelatedValidationSummary().errorList.length and model.isModified() %} |
There was a problem hiding this comment.
is it worth adding a unit test for this?
There was a problem hiding this comment.
I've written 2 unit tests for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.