Fix Cypress/TypeScript/VSCode integration #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After running various updates today (macOS and brew formulae and casks), I started seeing a few errors in the `integration_tests` folder: - in `integration_tests/tsconfig.json`, TS2688: `Cannot find type definition file for 'cypress'` and `Cannot find type definition file for 'express-session'` - in `integration_tests/**/*.ts`, TS2304: `Cannot find name 'cy'` and `Cannot find name` with various other Cypress-related objects The `typeRoots` change fixes the former, while the `include` change fixes the latter. This was hard to debug, but the following helped: - https://stackoverflow.com/a/53938729/4002016 (I think - as well as the Approved Premises config) - cypress-io/cypress#1152 (comment)
Gweaton
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After running various updates today (macOS and brew formulae and casks), I started seeing a few errors in the
integration_testsfolder:integration_tests/tsconfig.json, TS2688:Cannot find type definition file for 'cypress'andCannot find type definition file for 'express-session'integration_tests/**/*.ts, TS2304:Cannot find name 'cy'andCannot find namewith various other Cypress-related objectsChanges in this PR
The
typeRootschange fixes the former, while theincludechange fixes the latter. This was hard to debug, but the following helped: