api: add get_bucket_policy and set_bucket_policy. #385

balamurugana · 2016-07-15T18:45:19Z

Fixes ##377

harshavardhana · 2016-07-21T02:51:10Z

what else is needed here @balamurugana ?

harshavardhana · 2016-07-24T00:10:27Z

what else is needed here @balamurugana ?

Checking again what else is pending here to get this merged @balamurugana ?

balamurugana · 2016-07-27T11:21:09Z

There is an issue which delete policy. Fixing now.

Fixed in the latest refresh.

balamurugana · 2016-07-27T13:21:06Z

When running below sequence, there is a left over s3:ListBucket statement.

$ mc.set_bucket_policy(Policy.READ_ONLY, BUCKET, 'hello')
$ mc.set_bucket_policy(Policy.READ_WRITE, BUCKET, 'world')
$ mc.set_bucket_policy(Policy.READ_WRITE, BUCKET)
$ mc.set_bucket_policy(Policy.NONE, BUCKET)

Fixing it now.

Fixed in latest refresh.

balamurugana · 2016-07-28T03:28:47Z

Below policy JSON is set.

mc.set_bucket_policy(Policy.READ_ONLY, "mybucket", "hello")

{"Statement": [{"Action": "s3:GetBucketLocation",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": "s3:ListBucket",
                 "Condition": {"StringEquals": {"s3:prefix": "hello"}},
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": "s3:GetObject",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket/hello*",
                 "Sid": ""}],
 "Version": "2012-10-17"}

mc.set_bucket_policy(Policy.READ_WRITE, "mybucket", "world")

{"Statement": [{"Action": "s3:GetBucketLocation",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": "s3:GetObject",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket/hello*",
                 "Sid": ""},
                {"Action": "s3:ListBucket",
                 "Condition": {"StringEquals": {"s3:prefix": ["world", "hello"]}},
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": "s3:ListBucketMultipartUploads",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": ["s3:ListMultipartUploadParts",
                             "s3:GetObject",
                             "s3:AbortMultipartUpload",
                             "s3:DeleteObject",
                             "s3:PutObject"],
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket/world*",
                 "Sid": ""}],
 "Version": "2012-10-17"}

mc.set_bucket_policy(Policy.READ_WRITE, "mybucket")

{"Statement": [{"Action": "s3:GetBucketLocation",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": "s3:GetObject",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket/hello*",
                 "Sid": ""},
                {"Action": "s3:ListBucketMultipartUploads",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": ["s3:ListMultipartUploadParts",
                             "s3:GetObject",
                             "s3:AbortMultipartUpload",
                             "s3:DeleteObject",
                             "s3:PutObject"],
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket/world*",
                 "Sid": ""},
                {"Action": "s3:ListBucket",
                 "Condition": {"StringEquals": {"s3:prefix": ["world", "hello"]}},
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": "s3:ListBucket",
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket",
                 "Sid": ""},
                {"Action": ["s3:ListMultipartUploadParts",
                             "s3:GetObject",
                             "s3:AbortMultipartUpload",
                             "s3:DeleteObject",
                             "s3:PutObject"],
                 "Effect": "Allow",
                 "Principal": {"AWS": "*"},
                 "Resource": "arn:aws:s3:::mybucket/*",
                 "Sid": ""}],
 "Version": "2012-10-17"}

harshavardhana · 2016-07-28T05:40:25Z

minio/api.py

+
+        policy_dict = self._get_bucket_policy(bucket_name)
+        if policy_access == policy.Policy.NONE and not policy_dict:
+            return


We need to return an error here..We raise an exception. NoSuchBucketPolicy

harshavardhana · 2016-07-29T21:33:13Z

@balamurugana can you add examples, update README.md and API.md as well.

Fixes #minio#377

balamurugana · 2016-07-29T22:41:20Z

@balamurugana can you add examples, update README.md and API.md as well.

Done in latest refresh.

balamurugana force-pushed the devel branch from d622d8b to ed67744 Compare July 15, 2016 18:47

balamurugana force-pushed the devel branch from ed67744 to c22402d Compare July 27, 2016 10:55

balamurugana force-pushed the devel branch from c22402d to eeeabd0 Compare July 27, 2016 11:51

balamurugana force-pushed the devel branch from eeeabd0 to a7c8e23 Compare July 28, 2016 02:52

harshavardhana reviewed Jul 28, 2016
View reviewed changes

balamurugana force-pushed the devel branch from a7c8e23 to cada0cc Compare July 29, 2016 21:28

api: add get_bucket_policy and set_bucket_policy.

c40d48e

Fixes #minio#377

balamurugana force-pushed the devel branch from cada0cc to c40d48e Compare July 29, 2016 22:34

harshavardhana merged commit cad9fc0 into minio:master Jul 29, 2016

harshavardhana mentioned this pull request Aug 28, 2016

api: Add GetBucketPolicy, RemoveBucketPolicy and SetBucketPolicy #377

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api: add get_bucket_policy and set_bucket_policy. #385

api: add get_bucket_policy and set_bucket_policy. #385

balamurugana commented Jul 15, 2016

harshavardhana commented Jul 21, 2016

harshavardhana commented Jul 24, 2016

balamurugana commented Jul 27, 2016 •

edited

Loading

balamurugana commented Jul 27, 2016 •

edited

Loading

balamurugana commented Jul 28, 2016

harshavardhana Jul 28, 2016

harshavardhana commented Jul 29, 2016

balamurugana commented Jul 29, 2016

api: add get_bucket_policy and set_bucket_policy. #385

api: add get_bucket_policy and set_bucket_policy. #385

Conversation

balamurugana commented Jul 15, 2016

harshavardhana commented Jul 21, 2016

harshavardhana commented Jul 24, 2016

balamurugana commented Jul 27, 2016 • edited Loading

balamurugana commented Jul 27, 2016 • edited Loading

balamurugana commented Jul 28, 2016

harshavardhana Jul 28, 2016

Choose a reason for hiding this comment

harshavardhana commented Jul 29, 2016

balamurugana commented Jul 29, 2016

balamurugana commented Jul 27, 2016 •

edited

Loading

balamurugana commented Jul 27, 2016 •

edited

Loading