Add AssumeRoleWithCertificate credential provider. #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
780bda5 to
337664e
Compare
|
@balamurugana looks like you didn't test this with MinIO. You need to provide provisions for client.crt and client.key You haven't added any API that takes client certs. minio-go API takes tls.Certificate which is a private and public key certificate - https://pkg.go.dev/crypto/tls#Certificate |
337664e to
96273c7
Compare
harshavardhana
approved these changes
Feb 28, 2022
harshavardhana
requested changes
Feb 28, 2022
96273c7 to
bac7444
Compare
|
Tested the PR using self-signed certificates with ignoring certificate check using custom HTTP client. |
Signed-off-by: Bala.FA <bala@minio.io>
bac7444 to
4ce90b6
Compare
harshavardhana
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bala.FA bala@minio.io