Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global atmos upp job to use COMIN/COMOUT #1

Closed
wants to merge 7 commits into from

Conversation

mingshichen-noaa
Copy link
Owner

@mingshichen-noaa mingshichen-noaa commented Aug 19, 2024

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global-workflow Unified Post Processor (UPP) task.

Refs NOAA-EMC#2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

@mingshichen-noaa mingshichen-noaa self-assigned this Aug 19, 2024
@mingshichen-noaa mingshichen-noaa added the enhancement New feature or request label Aug 19, 2024
@DavidHuber-NOAA
Copy link

DavidHuber-NOAA commented Aug 26, 2024

FYI @aerorahul
@mingshichen-noaa Can you close this PR and reopen into NOAA-EMC/global-workflow?
@DavidHuber-NOAA Yes, I will close it and reopen it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants