Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Fix idempotency issue of device tracking by adding new user_device_tracking variable #24

Merged
merged 2 commits into from
Nov 25, 2020
Merged

fix!: Fix idempotency issue of device tracking by adding new user_device_tracking variable #24

merged 2 commits into from
Nov 25, 2020

Conversation

mariux
Copy link
Member

@mariux mariux commented Nov 25, 2020 •
edited
Loading

BREAKING CHANGES

  • fix!: Fix idempotency issue of device tracking by adding user_device_tracking variable
  • release: Prepare 0.3.0 release

fixes #23

@mariux mariux changed the title mariux/fix 23 fix!: Fix idempotency issue of device tracking by adding new user_device_tracking variable Nov 25, 2020
@mariux mariux marked this pull request as ready for review November 25, 2020 19:09
@mariux
Copy link
Member Author

mariux commented Nov 25, 2020

@soerenmartius tested against our staging cognito. Added migration hints to changelog.

soerenmartius
soerenmartius previously approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soerenmartius
Copy link
Member

Thanks for fixing this :)

@soerenmartius soerenmartius self-requested a review November 25, 2020 19:13
soerenmartius
soerenmartius approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mariux mariux merged commit c72fecf into master Nov 25, 2020
@mariux mariux deleted the mariux/fix-23 branch November 25, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soerenmartius soerenmartius soerenmartius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

terraform state is not idempotent if device tracking is off
2 participants
@mariux @soerenmartius