Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): fix set-output warnings #20

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

hmurtaza7
Copy link
Contributor

@hmurtaza7 hmurtaza7 commented Sep 29, 2023

an attempt to fix set-output warnings

this actions is being used in moodpath docker build and. publish
image

@raphaelluchini
Copy link
Contributor

That won't fix the issue.

You need to use:

echo "env_var=var_value" >> "$GITHUB_OUTPUT"

Copy link
Contributor

@raphaelluchini raphaelluchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be:
echo sha-tag=${GITHUB_SHA} >> $GITHUB_OUTPUT
echo ref-tag=${REF} >> $GITHUB_OUTPUT

Copy link
Contributor

@raphaelluchini raphaelluchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it will work with quotes sha-tag="${GITHUB_SHA}".

Let's try

@raphaelluchini raphaelluchini merged commit 54e1cf5 into master Sep 29, 2023
@raphaelluchini raphaelluchini deleted the chore/fix-warnings branch September 29, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants