Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skip_plan option to state migrator #152

Merged
merged 1 commit into from
Sep 21, 2023
Merged

add skip_plan option to state migrator #152

merged 1 commit into from
Sep 21, 2023

Conversation

mdb
Copy link
Contributor

@mdb mdb commented Sep 14, 2023

This addresses issue #151 to add a skip_plan option to single state migrations, similar to the from_skip_plan and to_skip_plan options supported by multi state migrations.

@mdb mdb marked this pull request as ready for review September 15, 2023 00:21
@mdb
Copy link
Contributor Author

mdb commented Sep 18, 2023

@minamijoyo Does this seem reasonable to you?

@minamijoyo
Copy link
Owner

@mdb Thank you for your proposal; I agree the state/multi_state feature parity makes sense.
I left a minor review comment for the test case.

This addresses issue #151 to add a `skip_plan` option to single state
migrations, similar to the `from_skip_plan` and `to_skip_plan` options
supported by multi state migrations.
@mdb mdb requested a review from minamijoyo September 20, 2023 19:48
Copy link
Owner

@minamijoyo minamijoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdb LGTM! Thanks 👍

@minamijoyo minamijoyo merged commit fe82d85 into minamijoyo:master Sep 21, 2023
@mdb mdb deleted the mdb/skip-plan branch September 21, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants