Fix failing import acceptance test #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e58103 to
7e25d4b
Compare
While implementing #111, we noticed that the import acceptance test for the `tfexec` package failed. #111 (comment) After investigation, I found that the time provider was significantly rewritten in v0.9.0 to migrate to the new `terraform-plugin-framework`. hashicorp/terraform-provider-time#112 As a result, the implementation of import for the `time_static` resource now implicitly sets the `triggers` attribute to an empty map `{}` instead of `null`. I’m not sure if this change was intentional or not, though; we can simply accept this change because there is no essential difference as long as the import success with no change.
7e25d4b to
be84cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing #111, we noticed that the import acceptance test for the
tfexecpackage failed.#111 (comment)
After investigation, I found that the time provider was significantly rewritten in v0.9.0 to migrate to the new
terraform-plugin-framework.hashicorp/terraform-provider-time#112
As a result, the implementation of import for the
time_staticresource now implicitly sets thetriggersattribute to an empty map{}instead ofnull.I’m not sure if this change was intentional or not, though; we can simply accept this change because there is no essential difference as long as the import success with no change.