-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GCS as a history storage #103
Conversation
Signed-off-by: Kengo TODA <skypencil+github@gmail.com>
Hi @KengoTODA, Thank you for working on this! I tried to test this branch with docker-compose, but failed to initialize the test fixture for storage_gcs.
I guess the error looks related to an issue mentioned in #23 (comment) by @w1mvy 🤔 @KengoTODA Was it successful on this branch in your environment? |
Signed-off-by: Kengo TODA <skypencil+github@gmail.com>
Thanks for your review! |
It works now. It's a bit tricky but acceptable to use s3 backend as Terraform state backend for testing gcs storage as tfmigrate history 👍 |
Signed-off-by: Kengo TODA <skypencil+github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve also confirmed that this works with a real gcs bucket. LGTM 👍
Thank you! |
@KengoTODA I've just released it in v0.3.7 🚀 Thank you for your contribution! |
Just like #23, this PR adds a support for GCS history backend.
But it provides less configurations than #23, refer to minamijoyo/tfmigrate-storage#3 for detail.