Use (cons 'buffer . buffer-object) as multi-category for candidates #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs testing and coordination with Embark before it can be merged. |
6c36aac to
1e17d55
Compare
This fixes the problem where buffers are renamed during completion. Renaming can happen during buffer name uniquify or due to EXWM renaming. See the issues #978 and #979. Consult buffer preview magically continues to work since `get-buffer` accepts both string and buffer arguments. I haven't tested Embark yet.
888393f to
41d4495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem where buffers are renamed during completion. Renaming can happen during buffer name uniquify or due to EXWM renaming. See the issues #978 and #979.
Consult buffer preview magically continues to work since
get-bufferaccepts both string and buffer arguments. I haven't tested Embark yet.