Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @testitem #922

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Use @testitem #922

merged 4 commits into from
Sep 19, 2022

Conversation

davidanthoff
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #922 (eca7171) into master (5734b0e) will increase coverage by 1.48%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage   83.32%   84.80%   +1.48%     
==========================================
  Files          39       39              
  Lines        4005     4014       +9     
==========================================
+ Hits         3337     3404      +67     
+ Misses        668      610      -58     
Flag Coverage Δ
unittests 84.80% <100.00%> (+1.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/explorer/explore.jl 62.66% <100.00%> (+3.51%) ⬆️
src/core/time_arrays.jl 91.64% <0.00%> (-0.21%) ⬇️
src/core/defcomp.jl 82.06% <0.00%> (+3.92%) ⬆️
src/core/show.jl 38.81% <0.00%> (+33.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@davidanthoff davidanthoff marked this pull request as ready for review September 18, 2022 04:57
Copy link
Collaborator

@lrennels lrennels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, primarily because tests pass and most changes seem mechanical ... hard to review all 54 files :)

@davidanthoff davidanthoff merged commit a5ccf8d into master Sep 19, 2022
@davidanthoff davidanthoff deleted the testitem branch September 19, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants