Use JSON.parse to limit exposure
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `JSON.load` on untrusted input is considered unsafe. While the MIME type definition files would presumably come from a trusted source, there doesn't seem to be a need for the "extra" stuff that `JSON.load` does in here, so switching over to the safer `JSON.parse` API should help to reduce exposure.
|
Thanks. I’ll get this merged soon. |
halostatue
added a commit
that referenced
this pull request
Oct 15, 2014
Use `JSON.parse` to limit exposure
|
👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, there are no pressing reasons for this change (as in, this is
not addressing an immediate security threat). It's just a preventive measure to
reduce unnecessary exposure.
Using
JSON.loadon untrusted input is considered unsafe. While the MIME typedefinition files would presumably come from a trusted source, there doesn't seem
to be a need for the "extra" stuff that
JSON.loaddoes in here, so switchingover to the safer
JSON.parseAPI should help to reduce exposure.