Remove grin lib re-exports from util crate #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…grin-wallet into thiserror_conversion
phyro
approved these changes
Aug 8, 2022
| # grin_api = { git = "https://github.com/mimblewimble/grin", tag = "v5.0.0-beta.2" } | ||
|
|
||
| # For bleeding edge | ||
| grin_core = { git = "https://github.com/mimblewimble/grin", branch = "master" } |
There was a problem hiding this comment.
nitpick: there are spaces/indentation that could be removed in this and other toml files
|
Yes, agreed. Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For convenience, the previous version of the code imported all grin libraries into the
utilcrate and re-exported them for the rest of the wallet crates. This was done so that changes to versions or branches could be made in one place.This is fine if the wallet is the only thing being compiled, but as discovered when working on the gui, importing libs for both
grinandgrin-walletcauses namespace conflicts.The only solution is to ensure all grin crates are referenced by their original path, which means that the re-export needs to be removed and the grin libs imported into the wallet crate-by-crate. This unfortunately also means that we now need to update versioning info for builds or local development in each and every crate except for just the util crate.
It would be very useful to figure out a way to make changes for development/build/releases in a single place using whatever tools cargo provides, but that will have to be a future endeavour.