-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show QR code for listener address #650
Conversation
@quentinlesceller are you the right person to ask for review/consideration of this feature? |
That looks really great, thank you for this, I'll take a look at it soon! |
I scanned the QR code in the stdout above and got what I expected 👍 |
ec5080c
to
98a5dcd
Compare
Force pushed to remove |
Ok, macos builds are still failing, even though nothing changed? Is there an issue with CI for macos right now? |
I just triggered a build on the master branch to see what is happening. My guess is that the macOS runner was updated. And as such llvm is not included anymore. Will keep you posted. |
Okay yes that was the issue. Once #652 is merged you can merge master into your branch to fix the CI issue. |
@quentinlesceller I just rebased this branch onto latest master. Should be good to go (again). |
All looks good, will merge over next day or so unless there are any objections |
Resolves #649.
To see it in action, compile and run
grin-wallet listen
. You will see your Slatepack address as usual, but now also with a scanable QR code:$ grin-wallet listen Password: 20220626 22:39:35.332 WARN grin_wallet_controller::controller - Starting Tor Hidden Service for API listener at address x5fnata4ge6fbj35hwojo2eynhxq5lgzr6e3q4lbd4unoxfmekbzw7qd, binding to 127.0.0.1:3415 20220626 22:39:37.720 WARN grin_wallet_controller::controller - Starting HTTP Foreign listener API server at 127.0.0.1:3415. 20220626 22:39:37.721 WARN grin_wallet_controller::controller - HTTP Foreign listener started. 20220626 22:39:37.722 WARN grin_wallet_controller::controller - Slatepack Address is: grin1ha9dqnquxy79pfma8kwfw6ycd8hsatxe37ymsutpru5dwh9vy2ps7xl420 █▀▀▀▀▀█ █▄▄ ▀ █▄ █▄▀▀█ ▀▄█▄█ █▀▀▀▀▀█ █ ███ █ █▀█▄██▄ █▄ █▀▀▄ █▄▀▄█ █ ███ █ █ ▀▀▀ █ █ ▄ ▀▄▄ █ ▄▀█ █▀ ▀▀▄▄ █ ▀▀▀ █ ▀▀▀▀▀▀▀ █ █▄█ ▀ █ ▀▄▀ ▀▄▀ ▀▄▀ ▀▀▀▀▀▀▀ █▄█▀█▀▀▄ ▄█▀ ▀ █▄ ▀ ▀█▀ ▀█▀ ▀▄▀▀▀█▀ ▀▄▄█▀▀▀▀▀▄▄▀ ▄ ▄ ▀▄██▀ ▄▀▀▀█ ▄▀ ▀▀ ▀▄▀▄█▀▀ █▄▄█ ▄█ ██ ▄█▄▄█ ██▀██▀▄▀▄█▄▀ █ ▀█▀▀█ ▀▀ ▀▄███▄ █▄▄▄ ▀█ ▄▄▀▄ ▀█ ▄▀▀▄ █▀▀▄ ▄██ █▄▀▄▄▀▄█▄▀▄▀▄ ██▀▄▀█▀█▀ ▀▄█ ▀▄ ▀▀ ██▀ ██▄▄▀ ▄ █ ▄██▀▀▀█▀ ▀▀ ▀ █▀ ██▄▀▄ ▀▄▀▄█▄ █▄▀▀▀▀█▀▀▀▀ ██▀ ▄▀▀▄ ▀█ ▄▄▄█ █▀ ▀ ▀ █ ▀██▀▀▀ █▀██ █ ▀▄█▄▀▄▀▀ ▀▄█▀▄▄ ▀▀▀▀▀▀▀▀▄▀██▀█▀ ▀▀▀ █ ▀█▀▀ █▄█ ▄ ▄ ▀█▄█▀▀▀▀ ▀ ▄ ▄ █▀ ▀ ▀▀ ▀ █▄▀█ ▀ ██▀▄▀▄▀█▄▀▀▀█▀▀▀█▄▀█ █▀▀▀▀▀█ ▄▀ █▀█▀▀██▄ ▄█▄ ▄▀ █ ▀ █ █▀ █ ███ █ ██▀ ▄▀▀█▀ ▄ ▄█▄ ██▄▀▀██▀█▀▀▄▀ █ ▀▀▀ █ ▀▄ ▄▀▄ █▀▀▀█▄▄▄ █ █▀▄▀ ▀ █ ▀▀▀▀▀▀▀ ▀▀ ▀▀▀▀▀▀▀▀ ▀ ▀▀▀▀ ▀▀ ▀▀▀▀▀