Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show QR code for listener address #650

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

cliik
Copy link
Contributor

@cliik cliik commented Jun 24, 2022

Resolves #649.

To see it in action, compile and run grin-wallet listen. You will see your Slatepack address as usual, but now also with a scanable QR code:

$ grin-wallet listen
Password:
20220626 22:39:35.332 WARN grin_wallet_controller::controller - Starting Tor Hidden Service for API listener at address x5fnata4ge6fbj35hwojo2eynhxq5lgzr6e3q4lbd4unoxfmekbzw7qd, binding to 127.0.0.1:3415
20220626 22:39:37.720 WARN grin_wallet_controller::controller - Starting HTTP Foreign listener API server at 127.0.0.1:3415.
20220626 22:39:37.721 WARN grin_wallet_controller::controller - HTTP Foreign listener started.
20220626 22:39:37.722 WARN grin_wallet_controller::controller - Slatepack Address is: grin1ha9dqnquxy79pfma8kwfw6ycd8hsatxe37ymsutpru5dwh9vy2ps7xl420


   █▀▀▀▀▀█  █▄▄ ▀ █▄ █▄▀▀█ ▀▄█▄█ █▀▀▀▀▀█
   █ ███ █ █▀█▄██▄ █▄ █▀▀▄ █▄▀▄█ █ ███ █
   █ ▀▀▀ █ █ ▄ ▀▄▄ █ ▄▀█ █▀ ▀▀▄▄ █ ▀▀▀ █
   ▀▀▀▀▀▀▀ █ █▄█ ▀ █ ▀▄▀ ▀▄▀ ▀▄▀ ▀▀▀▀▀▀▀
   █▄█▀█▀▀▄ ▄█▀ ▀ █▄ ▀ ▀█▀ ▀█▀ ▀▄▀▀▀█▀
    ▀▄▄█▀▀▀▀▀▄▄▀   ▄ ▄ ▀▄██▀ ▄▀▀▀█ ▄▀ ▀▀
   ▀▄▀▄█▀▀ █▄▄█ ▄█ ██ ▄█▄▄█ ██▀██▀▄▀▄█▄▀
   █   ▀█▀▀█ ▀▀ ▀▄███▄  █▄▄▄ ▀█ ▄▄▀▄  ▀█
   ▄▀▀▄ █▀▀▄ ▄██ █▄▀▄▄▀▄█▄▀▄▀▄ ██▀▄▀█▀█▀
    ▀▄█  ▀▄   ▀▀ ██▀ ██▄▄▀ ▄  █ ▄██▀▀▀█▀
   ▀▀ ▀ █▀  ██▄▀▄ ▀▄▀▄█▄ █▄▀▀▀▀█▀▀▀▀ ██▀
    ▄▀▀▄ ▀█  ▄▄▄█ █▀ ▀   ▀ █ ▀██▀▀▀ █▀██
   █ ▀▄█▄▀▄▀▀ ▀▄█▀▄▄ ▀▀▀▀▀▀▀▀▄▀██▀█▀ ▀▀▀
   █  ▀█▀▀ █▄█ ▄   ▄   ▀█▄█▀▀▀▀ ▀ ▄ ▄ █▀
   ▀ ▀▀  ▀ █▄▀█ ▀  ██▀▄▀▄▀█▄▀▀▀█▀▀▀█▄▀█
   █▀▀▀▀▀█ ▄▀ █▀█▀▀██▄ ▄█▄ ▄▀  █ ▀ █  █▀
   █ ███ █ ██▀ ▄▀▀█▀ ▄ ▄█▄ ██▄▀▀██▀█▀▀▄▀
   █ ▀▀▀ █ ▀▄ ▄▀▄ █▀▀▀█▄▄▄ █ █▀▄▀ ▀    █
   ▀▀▀▀▀▀▀ ▀▀  ▀▀▀▀▀▀▀▀  ▀ ▀▀▀▀ ▀▀ ▀▀▀▀▀




@cliik
Copy link
Contributor Author

cliik commented Jun 26, 2022

@quentinlesceller are you the right person to ask for review/consideration of this feature?

@yeastplume
Copy link
Member

That looks really great, thank you for this, I'll take a look at it soon!

@phyro
Copy link
Member

phyro commented Jun 27, 2022

I scanned the QR code in the stdout above and got what I expected 👍

@cliik cliik force-pushed the listener-qrcode branch 2 times, most recently from ec5080c to 98a5dcd Compare June 30, 2022 12:36
@cliik
Copy link
Contributor Author

cliik commented Jun 30, 2022

Force pushed to remove qr_code from controller/src/lib.rs, as I realize it wasn't needed there, but then macos builds failed in CI, so I force pushed it back 🤦

@cliik cliik force-pushed the listener-qrcode branch from 98a5dcd to 6ed74cc Compare June 30, 2022 12:39
@cliik
Copy link
Contributor Author

cliik commented Jun 30, 2022

Ok, macos builds are still failing, even though nothing changed? Is there an issue with CI for macos right now?

@quentinlesceller
Copy link
Member

I just triggered a build on the master branch to see what is happening. My guess is that the macOS runner was updated. And as such llvm is not included anymore. Will keep you posted.

@quentinlesceller
Copy link
Member

Okay yes that was the issue. Once #652 is merged you can merge master into your branch to fix the CI issue.

@cliik cliik force-pushed the listener-qrcode branch from 6ed74cc to ee9aed8 Compare July 1, 2022 00:46
@cliik
Copy link
Contributor Author

cliik commented Jul 1, 2022

@quentinlesceller I just rebased this branch onto latest master. Should be good to go (again).

@yeastplume
Copy link
Member

All looks good, will merge over next day or so unless there are any objections

@yeastplume yeastplume merged commit 7b1eab6 into mimblewimble:master Jul 12, 2022
@cliik cliik deleted the listener-qrcode branch July 13, 2022 03:32
bayk added a commit to mwcproject/mwc-wallet that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Display QR code for slatepack address
4 participants