remove height argument from fee related functions as per fixpastfees RFC

[tromp]

name: fixpastfees
about: remove dependence of fee() and fee_shift() functions on height
title: 'fix past fees'

Companion PR for

mimblewimble/grin#3629

both implementing RFC https://github.com/mimblewimble/grin-rfcs/blob/master/text/0021-fix-prior-fees.md
to extend the 40 bit fee restriction and use of fee shifts back beyond HF4 to all history.
Technically a Hard Fork, but if we have a many month reorg introducing a > 40 bit fee prior to HF4, we have bigger problems to deal with than a chain split.

This simplifies all fee related functions as they no longer need a height argument to distinguish preHF4 from postHF4 behaviour.

[phyro]

@tromp this one seems to have some failing tests. I also suggest you add the same reviewers as on the grin node fixfees PR

[tromp]

I can't figure out the build failures?!
I click on the error annotations but it just shows the file diff.

[tromp]

how to add reviewers again?

[GeneFerneau]

I can't figure out the build failures?!

Looks like it's pulling in an old version of grin without the fee changes:

error[E0061]: this function takes 1 argument but 0 arguments were supplied
   --> libwallet/src/api_impl/owner.rs:406:17
    |
406 |             Some(f) => f.fee(), // apply fee mask past HF4
    |                          ^^^- supplied 0 arguments
    |                          |
    |                          expected 1 argument
    |
note: associated function defined here
   --> /home/vsts/.cargo/git/checkouts/grin-b002917b6a725898/f6ec77a/core/src/core/transaction.rs:173:9
    |
173 |     pub fn fee(&self, height: u64) -> u64 

Might need to do a test build locally, and commit the Cargo.lock after updating grin dependencies to point to master.

[GeneFerneau]

Had to run a cargo update to bump the master version locally, maybe the CI needs it too?

cargo update && \
...

in https://github.com/tromp/grin-wallet/blob/fixpastfees/.ci/general-jobs#L23

similar in:

• https://github.com/tromp/grin-wallet/blob/fixpastfees/.ci/test.yml#L6
• https://github.com/tromp/grin-wallet/blob/fixpastfees/.ci/test.yml#L10
• https://github.com/tromp/grin-wallet/blob/fixpastfees/.ci/windows-release.yml#L7

Do you know of a better way to do this globally for all the test builds?

[tromp]

Oops; i ran a cargo update on my local repo and commited the new Cargo.lock which now conflicts.
I'll await the advice of experts on how to resolve this...

[quentinlesceller]

LGTM 👍