Changed pub_nonce_sum and msg_to_sign to be public functions #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBurkett
approved these changes
Feb 27, 2021
There was a problem hiding this comment.
Seems reasonable to me. @quentinlesceller or @antiochp, can you merge this?
bayk
added a commit
to mwcproject/mwc-wallet
that referenced
this pull request
Aug 2, 2024
… be public functions (mimblewimble#557)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like
pub_blind_sum(&self, secp: &secp::Secp256k1)is a public functionpub_nonce_sum(&self, secp: &secp::Secp256k1)andmsg_to_sign(&self)should be too, as wallets that generate signatures outside of the slate context (not by usingfill_round_2) have to have access to those values.For instance in cases where signing requires a different approach than what is implemented in
fill_round_2such as where a secret key and nonce for a coin is split between two parties rather than one.