Deprecate HTTP(S)

[jaspervdm]

Implementation of the Deprecate HTTP(S) Transactions RFC.

[j01tz]

Looks good overall, thanks for taking care of this @jaspervdm.

I ran it on a test instance with Tor not installed and got following output

20201124 09:45:40.939 WARN grin_wallet_controller::controller - Starting TOR Hidden Service for API listener at address rglop53gkfop22lfka5z2juxsv4f6uciwseg7dslsay72otevsrsupyd, binding to 127.0.0.1:13415
20201124 09:45:40.944 WARN grin_wallet_controller::controller - Unable to start TOR listener; Check that TOR executable is installed and on your path
20201124 09:45:40.944 WARN grin_wallet_controller::controller - Tor Error: Tor Process Error: Process("TOR executable (`tor`) not found. Please ensure TOR is installed and on the path: Os { code: 2, kind: NotFound, message: \"No such file or directory\" }")
20201124 09:45:40.944 WARN grin_wallet_controller::controller - Listener will be available via HTTP only
20201124 09:45:40.945 WARN grin_wallet_controller::controller - Starting HTTP Foreign listener API server at 127.0.0.1:13415.
20201124 09:45:40.945 WARN grin_wallet_controller::controller - HTTP Foreign listener started.

I think it is doing what we expect but a couple of usability things that may be worth noting for a future PR:

• do we want the first log line above to return a tor address or a slatepack address? this could add confusion to return a raw tor address (or am I missing something in how the API is done?)
• even though http is no longer supported, the warning logs can confuse a user into thinking http is still working

[j01tz]

With this change, is there any reason to import or keep around any of the keybase logic in adapters?

[jaspervdm]

Afaik we still support Keybase as a method. This particular block of code was just unused so I got rid of it entirely.

[antiochp]

• do we want the first log line above to return a tor address or a slatepack address? this could add confusion to return a raw tor address (or am I missing something in how the API is done?)

I have previously seen that tor address in the logs and attempted to use it as an address when testing sending from the wallet.

[antiochp]

Looks good to me. 👍

[jaspervdm]

@j01tz
(i edited your comment by accident instead of replying to it, my bad)

even though http is no longer supported, the warning logs can confuse a user into thinking http is still working

Technically we still have a HTTP listener, it just runs locally. This listener is also used by the TOR hidden service. But I do agree we could improve on the text here in a future PR.